Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Aug 2021 20:49:10 +0200
From:      Hans Petter Selasky <hps@selasky.org>
To:        Andrew Gallatin <gallatin@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 2694c869ff9f - main - ktls: fix a panic with INVARIANTS
Message-ID:  <b4ae5fcf-31d3-6864-8df0-a468fd58f637@selasky.org>
In-Reply-To: <202108051710.175HAP1D031061@gitrepo.freebsd.org>
References:  <202108051710.175HAP1D031061@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 8/5/21 7:10 PM, Andrew Gallatin wrote:
> +		tsleep_sbt(sc, PZERO, "waiting for work", SBT_MAX, SBT_1S, 0);

Hi,

This basically puts a useless callout into the timer subsystem forever. 
I think if you don't care about this tsleep being accurate, then lock 
Giant and use sbt = 0.

In between, I think that assert in question should be updated.

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b4ae5fcf-31d3-6864-8df0-a468fd58f637>