Date: Sat, 23 Jul 2005 12:28:02 -0700 From: Doug Barton <dougb@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: grog@freebsd.org, freebsd-current@freebsd.org Subject: Re: cvs commit: src/games/fortune/fortune fortune.c Message-ID: <42E29A42.7040203@FreeBSD.org> In-Reply-To: <20050723.130941.93453281.imp@bsdimp.com> References: <20050723020120.GV842@wantadilla.lemis.com> <42E1DFCE.6090506@FreeBSD.org> <20050723064449.GZ842@wantadilla.lemis.com> <20050723.130941.93453281.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
M. Warner Losh wrote: > In message: <20050723064449.GZ842@wantadilla.lemis.com> > "Greg 'groggy' Lehey" <grog@frg. eebsd.org> writes: > : You should take a look at what I committed. It simply uses the > : microsecond value returned by getlocaltime() for the automatic seeding > : by srandomdev(). It fixes the problem. I can see only two > : explanations: > : > : 1. srandomdev(), random(4) or friends are broken. > : 2. random(4) has been initialized incorrectly. > : > : Currently I'm guessing (2), but I don't care much either way. > > When sradnomdev() is broken, *DO*NOT* kludge around them by committing > half-baked "fixes" like you did. I agree with you in principal Warner, but it's not at all clear that the real problem is srandomdev(). For instance, I just took a look at my laptop and noticed that there was still an old version of the fortunes2 file in /usr/share/games/fortune. The first fortune in that file is the one that I have been seeing with much greater frequency than the others, so I deleted those old files and we'll see what happens from here. I also changed my fortune invocation in my shell startup file to: /usr/games/fortune -D -D -D -sa 2>$HOME/fortune-debug sysctl kern.random.sys.seeded >> $HOME/fortune-debug Hopefully that will tell us something interesting. Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42E29A42.7040203>