Date: Tue, 01 Nov 2016 20:16:26 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 213985] science/avogadro: fix for lang/gcc5 Message-ID: <bug-213985-13-3VS0I7jaFx@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-213985-13@https.bugs.freebsd.org/bugzilla/> References: <bug-213985-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213985 --- Comment #1 from Gerald Pfeifer <gerald@FreeBSD.org> --- Thanks for looking into this, Kenneth! I am not familiar with this port, nor even Eigen, so I hope some other committer will grab this, but one comment/suggestion on this patch: ++// fix for lang/gcc5 ++#if __GNUC__ =3D=3D 5 && __GNUC_MINOR__ =3D=3D 4 ++#undef minor ++#endif Why check for __GNUC_MINOR__, especially with =3D=3D? What if the lang/gcc5 port is updated to version 5.5? Wouldn't it be best to just check for __GNUC__, ignoring __GNUC_MINOR__, and perhaps even __GNUC__ >=3D 5? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-213985-13-3VS0I7jaFx>