Date: Wed, 2 Apr 2003 10:18:32 -0800 (PST) From: Nate Lawson <nate@root.org> To: SUZUKI Shinsuke <suz@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/rtadvd config.c Message-ID: <Pine.BSF.4.21.0304021017260.11936-100000@root.org> In-Reply-To: <20030402113558.1A93537B417@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2 Apr 2003, SUZUKI Shinsuke wrote: > Modified files: > usr.sbin/rtadvd config.c > Log: > fixed invalid pointer reference > > Obtained from: KAME > > Revision Changes Path > 1.13 +1 -0 src/usr.sbin/rtadvd/config.c > > > Index: src/usr.sbin/rtadvd/config.c > diff -u src/usr.sbin/rtadvd/config.c:1.12 src/usr.sbin/rtadvd/config.c:1.13 > --- src/usr.sbin/rtadvd/config.c:1.12 Mon Dec 30 13:18:15 2002 > +++ src/usr.sbin/rtadvd/config.c Wed Apr 2 03:35:51 2003 > @@ -1,4 +1,4 @@ > -/* $FreeBSD: /repoman/r/ncvs/src/usr.sbin/rtadvd/config.c,v 1.12 2002/12/30 21:18:15 schweikh Exp $ */ > +/* $FreeBSD: /repoman/r/ncvs/src/usr.sbin/rtadvd/config.c,v 1.13 2003/04/02 11:35:51 suz Exp $ */ > /* $KAME: config.c,v 1.37 2001/05/25 07:34:00 itojun Exp $ */ > > /* > @@ -630,6 +630,7 @@ > > /* link into chain */ > insque(pp, &rai->prefix); > + pp->rainfo == rai; > > /* counter increment */ > rai->pfxs++; I think you want assignment, not equivalence test, especially since you deref the pointer immediately afterwards. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0304021017260.11936-100000>