Date: Fri, 13 Jul 2001 09:57:00 -0700 From: Dima Dorfman <dima@unixfreak.org> To: Hajimu UMEMOTO <ume@imasy.or.jp> Cc: ru@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/libexec/talkd announce.c Message-ID: <20010713165700.BDE8A3E2F@bazooka.unixfreak.org> In-Reply-To: <ygehewg7r5q.wl@piano.mahoroba.org>; from ume@imasy.or.jp on "Sat, 14 Jul 2001 01:03:13 %2B0900"
next in thread | previous in thread | raw e-mail | index | archive | help
Hajimu UMEMOTO <ume@imasy.or.jp> writes: > >>>>> On Fri, 13 Jul 2001 08:36:47 -0700 > >>>>> Dima Dorfman <dima@unixfreak.org> said: > > dima> Ruslan Ermilov <ru@FreeBSD.org> writes: > > On Fri, Jul 13, 2001 at 07:11:49AM -0700, Dima Dorfman wrote: > > > dd 2001/07/13 07:11:49 PDT > > > > > > Modified files: (Branch: RELENG_4) > > > libexec/talkd announce.c > > > Log: > > > MFC 1.12: print the date in the announcement. > > > > > > Revision Changes Path > > > 1.11.2.1 +4 -2 src/libexec/talkd/announce.c > > > > > What about my idea of also printing the party's IP address > > (hostname) if it's different from the called one? > > dima> I'm not sure what you're suggesting, or what it has to do with this > dima> commit. I've attached a rather crude patch that implements what I > dima> think you mean. It changes the "[Connection established.]" message to > dima> "[Connection established with user@host.]". > > Please stop using gethostbyaddr() and IPv4 specific coding anymore. > We have getnameinfo() for this purpose. I did think about that when writing that code (I like the new interface so much better than the crufty old one), but talk assumes IPv4 so much that it really doesn't matter, and deviating from that here only leads to inconsistency. I doubt talk works over IPv6, and looking at /usr/include/protocols/talkd.h, I don't think it's trivial (if possible) to make it work over IPv6 without breaking backwards comaptibility. Perhaps a talk6 is in order? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010713165700.BDE8A3E2F>