Date: Tue, 23 Jan 2018 16:17:54 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Tobias Kortkamp <tobik@FreeBSD.org> Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r459753 - in head/deskutils: . freeplane freeplane/files Message-ID: <20180123151754.u6hwtlzqqtzkckvo@aragorn.in.absolight.net> In-Reply-To: <1516720372.2689994.1245262664.06EEC8C7@webmail.messagingengine.com> References: <201801231415.w0NEFuvx082953@repo.freebsd.org> <20180123141944.GB73049@FreeBSD.org> <1516720372.2689994.1245262664.06EEC8C7@webmail.messagingengine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--yauvydlemksda5rg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 23, 2018 at 04:12:52PM +0100, Tobias Kortkamp wrote: > On Tue, Jan 23, 2018, at 15:19, Alexey Dokuchaev wrote: > > On Tue, Jan 23, 2018 at 02:15:56PM +0000, Tobias Kortkamp wrote: > > > New Revision: 459753 > > > URL: https://svnweb.freebsd.org/changeset/ports/459753 > > >=20 > > > Log: > > > New port: deskutils/freeplane > > > =20 > > > Added: head/deskutils/freeplane/Makefile > > > ... > > > @@ -0,0 +1,35 @@ > > > +# Created by: Lo??c Bartoletti <lbartoletti@tuxfamily.org> > > > +# $FreeBSD$ > >=20 > > ASCII please. > >=20 > > > +# Install freeplane.sh with the right permission, link to it to bin/ > > > +# and let it resolve the path to DATADIR automatically to avoid > > > +# patching it further. For this to work it has to be a link to an > > > +# absolute path. > > > + ${INSTALL_SCRIPT} ${WRKSRC}/freeplane.sh ${STAGEDIR}${DATADIR} > > > + ${LN} -s ${DATADIR}/freeplane.sh ${STAGEDIR}${PREFIX}/bin/freeplane > >=20 > > Symlinks pointing to an absolute path are bad. > >=20 > > ./danfe >=20 > Can you please explain why they "are bad"? They are bad when they reference LOCALBASE or PREFIX. https://www.freebsd.org/doc/en/books/porters-handbook/special.html#staging-= symlink --=20 Mathieu Arnold --yauvydlemksda5rg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlpnUiBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkh7ug//UahPJ9Xa4Wao++DM6UV10+CrE3mW3snJz/WcMqD9TSFxy7ZM7Vv8QUr1 7s0Mp6kEajjP12dc3TdZ4e1WXYMO6guWz96gqw+CHyKzVrKWilQOhQSd+h6Ra+55 sJ1sj60NopmcDlngXfSJFtNYljQ7lhJsClAC6HENCE+N5NXjpjena5lJVzWOH4TN 0RLKQ8en760lNiZB+HN8qcDCPSqBIeDMkUnUqpxLDa+T81yKyHH/ybpcLjtXn9N3 +arLq6NJhwgvNzzy/GyMv5AXOV8NQ+1e6hd61TDK9hdjOfNyWXsKYVo/R3bWoNz2 qCKZIeFDf6Xgq4kjm2/QgmSQpdvT79aNhFFXDUpyU+VdM1vrqUZXoNjSmaF4R2sz 7YA07ks6Wp+4qflCJzGibkQgx26y+ZYneFUml/tUmy0DF4FLQFw2aaek8bGwTMzo lB/xBsTZHdZYhA4voSOwiiGr4tI4ISnv74MezWTwLBLQ/iuJ+Jgv4fSwjnUeN+aj u/in1tN6+Z+l7Pz3QRhIZLrqaTGuGnUKoBINnc0EEwNKlv8kDKNccHmW74vicMD1 u6p/8Fq2nt5T59mcjMYokyQFS4vcjIt3SXVW/iYyCJSwIPkgEoxyOnW0aw27Qgo7 r+v20uw1BB+p4gmuevEPOYF0M8NJZpRhwNjKsYEiFgMLzfYvwvw= =8sri -----END PGP SIGNATURE----- --yauvydlemksda5rg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180123151754.u6hwtlzqqtzkckvo>