Date: Thu, 7 Mar 2002 08:59:38 -0700 From: Nate Williams <nate@yogotech.com> To: Mark Murray <mark@grondar.za> Cc: obrien@FreeBSD.org, Mark Murray <markm@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <15495.36458.825910.324111@caddis.yogotech.com> In-Reply-To: <200203071210.g27CA8RV010023@grimreaper.grondar.org> References: <20020307033328.A64158@dragon.nuxi.com> <200203071210.g27CA8RV010023@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > On Thu, Mar 07, 2002 at 11:27:02AM +0000, Mark Murray wrote: > > > > - if ((fd = mkstemp(tmpname)) == -1 || !(fp = fdopen(fd, "r+"))) > > > > + fd = mkstemp(tmpname); > > > > + fp = fdopen(fd, "r+"); > > > > + if (fd == -1 || !fp) > > > > > > > > Why did you need to do such code restructuring? > > > > > > "Assignment statement in conditional". I also happens to be more readable. > > > > Feh. Please back this type of changes out. The logic is not the same > > before and after. > > Here is the clearer fix: > > @@ -137,8 +136,10 @@ > > snprintf(tmpname, sizeof(tmpname), "%s/wall.XXXXXX", _PATH_TMP); > fd = mkstemp(tmpname); > - fp = fdopen(fd, "r+"); > - if (fd == -1 || !fp) > + fp = NULL; > + if (fd != -1) > + fp = fdopen(fd, "r+"); > + if (fp == NULL) > err(1, "can't open temporary file"); > unlink(tmpname); I would argue the original code is *much* clearer. Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15495.36458.825910.324111>