Date: Thu, 05 Apr 2007 03:12:20 -0400 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: freebsd-hackers@FreeBSD.org Subject: Problem with test(1) Message-ID: <1175757140.67579.50.camel@shumai.marcuscom.com>
next in thread | raw e-mail | index | archive | help
--=-0d2p97g5INxa84DmiEQ0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I noticed something weird with test(1) when I ran across a problem port Makefile. Our test(1) doesn't properly check to make sure there is an operand argument to unary operators like -f. For example: test -f Will print "TRUE" on FreeBSD. On Solaris, it will die: /usr/bin/test[8]: test: argument expected I think this patch is correct in that it does fix the problem, and the TEST.sh and TEST.csh regression scripts report the same results pre and post-patch. Comments? http://www.marcuscom.com/downloads/text.c.diff Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-0d2p97g5INxa84DmiEQ0 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBGFKFUb2iPiv4Uz4cRAnwgAJ0UCyafuPl+bJXC9bEb2J5S7fGyfwCeKqkS taxT5HQGwJDbYz7auoxFLbs= =pQwD -----END PGP SIGNATURE----- --=-0d2p97g5INxa84DmiEQ0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1175757140.67579.50.camel>