Date: Mon, 03 Nov 2014 11:29:59 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: freebsd-arch@freebsd.org, Warner Losh <imp@bsdimp.com> Subject: Re: Why do we have @ in modules builds? Message-ID: <5457D7B7.5050503@freebsd.org> In-Reply-To: <64C28D7A-AD81-4990-B95C-47E81C0E4F0A@bsdimp.com> References: <3285BC54-05D8-41DB-88FE-BAD681A3E45B@bsdimp.com> <5457D2D0.8080201@freebsd.org> <64C28D7A-AD81-4990-B95C-47E81C0E4F0A@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/3/14, 11:22 AM, Warner Losh wrote: > On Nov 3, 2014, at 12:09 PM, Alfred Perlstein <alfred@freebsd.org> wrote: > >> On 11/3/14, 8:48 AM, Warner Losh wrote: >>> Does anybody recall why we have @ symlink in our module builds? >>> I’m constantly working around issues that this creates. Maybe it is time >>> to eliminate it? >>> >>> So I’ve posted the following review: https://reviews.freebsd.org/D1100 >>> >>> Warner >>> >> Thank you!!!! I hate the '@' thing as well, I figured it was just due to someone not wanting 'grep -r' to work. :) >> >> Just to check, after your changes... will you still be able to do something like: >> >> cd $HOME >> svn co https://.../base/head/sys/modules/foo_module >> cd foo_module >> make depend all install > It should behave the same it does today. I’m replacing a ln -s ${SYSDIR} @ with an in-line replacement of @ with ${SYSDIR}. Excellent! I did a history check to see why these came to be and it looks like it was just an oversight to use "@ links" instead of just SYSDIR as far as I can tell... -Alfred > Warner >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5457D7B7.5050503>