Date: Wed, 5 Sep 2001 08:45:49 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include/arpa tftp.h Message-ID: <20010905084549.A95963@dragon.nuxi.com> In-Reply-To: <20010905203608.K22645-100000@alphplex.bde.org>; from bde@zeta.org.au on Wed, Sep 05, 2001 at 08:39:34PM %2B1000 References: <20010904185643.A78975@dragon.nuxi.com> <20010905203608.K22645-100000@alphplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 05, 2001 at 08:39:34PM +1000, Bruce Evans wrote:
> > > > Log:
> > > > style(9) the structure definitions.
> > > Was this *really* necessary?
> > > I thought we had a policy against doing broad sweeps of
> > > non-substantive changes like this.
> >
> > Yes it was -- we were so confused (partically do to your commit to
> > style.9) that one could not figure out what was right. Now enough of the
> > key places to look for style guidlines have been fixed. I don't plan on
> > sweaping any more of the tree to just fix this.
>
> The existence of both in old code means that they were both right.
The CSRG people can make mistakes too -- just like we do. Several of our
headers I cleaned up used _both_ <space> and <tab>. You guys keep
pointing to the single kernel header that was inconsistent with the
others in struct definition style. I looked at many headers in my CSRG
SCCS repo. The vast majority were "struct<space>foo {".
> "struct\t.*{" does seem to be the least normal form although it is used
> in the oldest code (proc.h...), but you shouldn't have changed it while
> we are still discussing this.
What more was there to discuss?
This issue is one that is pretty easy to decide based on facts. When
there is a 3:1 ratio of <space> to <tab> in our own code (and as you
pointed out most of those were <tab> due to makesyscalls.sh. (the ratio
was higher in the CSRG code).
--
-- David (obrien@FreeBSD.org)
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010905084549.A95963>