Date: Mon, 6 Apr 2015 20:07:33 -0600 From: Adam Weinberger <adamw@adamw.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r383472 - head/audio/muse Message-ID: <91AB85D3-A8DE-491C-A2D7-4E8D7E1CDC12@adamw.org> In-Reply-To: <20150407012902.GA22994@FreeBSD.org> References: <201504061859.t36IxK0v000969@svn.freebsd.org> <20150407012902.GA22994@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 6 Apr, 2015, at 19:29, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >=20 > On Mon, Apr 06, 2015 at 06:59:20PM +0000, Sunpoet Po-Chuan Hsieh = wrote: >> New Revision: 383472 >> URL: https://svnweb.freebsd.org/changeset/ports/383472 >>=20 >> [...] >> @@ -52,6 +49,6 @@ post-patch: >>=20 >> post-install: >> @${MKDIR} ${STAGEDIR}${DOCSDIR} >> - ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} = ${STAGEDIR}${DOCSDIR} >> + (cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} = ${STAGEDIR}${DOCSDIR}) >=20 > Please do not change working and readable code into equivalent = less-readable > one. ${PORTDOCS:S,^,${WRKSRC}/,} is not readable. Especially not compared to the pseudo-English statement = into which sunpoet expanded it: cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} Alexey, you've been ramping up the style policing lately. You're not = getting much attention when you are choosing a different thing to care = about each day. Pick just one or two topics that are most important to = you, and work to get those behaviors fixed. Otherwise, sorry bud, you're = just micro-managing. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?91AB85D3-A8DE-491C-A2D7-4E8D7E1CDC12>