Date: Thu, 13 Sep 2001 17:46:12 +0100 From: Brian Somers <brian@freebsd-services.com> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Dag-Erling Smorgrav <des@ofug.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c Message-ID: <200109131646.f8DGkCd92727@hak.lan.Awfulhak.org> In-Reply-To: Message from Ruslan Ermilov <ru@FreeBSD.org> of "Thu, 13 Sep 2001 13:06:10 %2B0300." <20010913130610.B35618@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, Sep 13, 2001 at 11:29:08AM +0200, Dag-Erling Smorgrav wrote: > > Ruslan Ermilov <ru@FreeBSD.org> writes: > > > With this, the patch looks almost the same as it was in my reply. > > > Modulo the stripping of the terminal dot. > > > > Sorry, but all your patches are incorrect as they do not allow for the > > (perfectly valid) local.host.localdomain.net -> local.host scenario. > > The only thing missing from my second commit was a strcasecmp() call. > > > Right, I did realize that. Your last patch looks OK modulo minor > style bugs (missing spaces surrounding `+' and `-' operators). With my eyes tied behind my head and not looking at the code.... shouldn't we be using trimdomain() and -lutil ? > Cheers, > -- > Ruslan Ermilov Oracle Developer/DBA, > ru@sunbay.com Sunbay Software AG, > ru@FreeBSD.org FreeBSD committer, > +380.652.512.251 Simferopol, Ukraine > > http://www.FreeBSD.org The Power To Serve > http://www.oracle.com Enabling The Information Age -- Brian <brian@freebsd-services.com> <brian@Awfulhak.org> http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org> Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109131646.f8DGkCd92727>