Date: Thu, 21 May 2015 09:36:05 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Ed Maste <emaste@freebsd.org> Cc: Oliver Pinter <oliver.pinter@hardenedbsd.org>, Wolfgang Zenker <wolfgang@lyxys.ka.sub.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Race VT+X11 on -current Message-ID: <555D8AE5.4030704@selasky.org> In-Reply-To: <CAPyFy2CiXAaO6akMQQgdxN6Ya=QK-FEVpBmiCkkEK--6bWFSdg@mail.gmail.com> References: <CAN6yY1vno%2B-nV9zBYp11A=F-vAURbhraEFyQR_ue4W7h8pQUMw@mail.gmail.com> <AA8B24D1-DF5A-42CD-8755-15EF3C46E760@gmail.com> <554BC475.50203@selasky.org> <554BD2A8.70702@selasky.org> <554C3CCB.3030809@selasky.org> <4937E44E-C0EF-4052-961C-F46D5EC5BE00@gmail.com> <554C8AEB.2080502@selasky.org> <554CC841.60908@freebsd.org> <20150509210525.GA80848@lyxys.ka.sub.org> <554F5379.2070100@selasky.org> <20150510165330.GA86856@lyxys.ka.sub.org> <554F8BA6.9000702@selasky.org> <CAPQ4ffuBNahdwrj6kGustSBk9V3qr1CP%2B-5__Cp-F2wqbB6=Rg@mail.gmail.com> <554F91DE.8010209@selasky.org> <CAPyFy2CiXAaO6akMQQgdxN6Ya=QK-FEVpBmiCkkEK--6bWFSdg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/11/15 21:52, Ed Maste wrote: > On 10 May 2015 at 13:14, Hans Petter Selasky <hps@selasky.org> wrote: >> >> Your patch is correct from what I can see. Signed modulus can be creepy >> sometimes! Better if VT_MAXWINDOWS was power of two and we used a bitwise >> AND. > > The patch is correct, although signedness doesn't come into play. The > unsigned vw_number just wraps to 2^32-1, which is 3 modulo 12. FYI: https://svnweb.freebsd.org/changeset/base/283187 --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?555D8AE5.4030704>