Date: Wed, 2 Oct 2019 15:08:07 -0700 From: Chuck Silvers <chs@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r352312 - in head: lib/geom/nop sys/geom/nop Message-ID: <20191002220807.GA3971@spathi.chuq.com> In-Reply-To: <CAOtMX2jcBD2YMwjS51k9%2B%2Be0TZ%2B4Nw7bPFbkHPDGtmg_OmcTxQ@mail.gmail.com> References: <201909132303.x8DN3uw3026373@repo.freebsd.org> <CAOtMX2jcBD2YMwjS51k9%2B%2Be0TZ%2B4Nw7bPFbkHPDGtmg_OmcTxQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 02, 2019 at 08:11:57AM -0600, Alan Somers wrote: > On Fri, Sep 13, 2019 at 5:04 PM Chuck Silvers <chs@freebsd.org> wrote: > > > Author: chs > > Date: Fri Sep 13 23:03:56 2019 > > New Revision: 352312 > > URL: https://svnweb.freebsd.org/changeset/base/352312 > > > > Log: > > Add a "count_until_fail" option to gnop, which says to start failing > > I/O requests after the given number have been allowed though. > > > > Approved by: imp (mentor) > > Reviewed by: rpokala kib 0mp mckusick > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D21593 > > > > Modified: > > head/lib/geom/nop/geom_nop.c > > head/lib/geom/nop/gnop.8 > > head/sys/geom/nop/g_nop.c > > head/sys/geom/nop/g_nop.h > > > > This patch introduces a backwards-compatibility bug. On a system with a > post-352312 kernel but a pre-352312 userland, the gnop command will always > fail with the error "gnop: Missing count_until_fail argument". > -Alan Thanks for pointing this out, I'll see about fixing it right away. -Chuck
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191002220807.GA3971>