Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Jun 2019 20:01:54 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
To:        Cy Schubert <cy@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r349450 - head/contrib/ipfilter/tools
Message-ID:  <201906270301.x5R31sLH057763@gndrsh.dnsmgr.net>
In-Reply-To: <201906270243.x5R2hUZx070792@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: cy
> Date: Thu Jun 27 02:43:30 2019
> New Revision: 349450
> URL: https://svnweb.freebsd.org/changeset/base/349450
> 
> Log:
>   Update usage() to refect the current state of ipmon.
>   
>   PR:		238816
>   MFC after:	1 week
> 
> Modified:
>   head/contrib/ipfilter/tools/ipmon.c
> 
> Modified: head/contrib/ipfilter/tools/ipmon.c
> ==============================================================================
> --- head/contrib/ipfilter/tools/ipmon.c	Thu Jun 27 02:43:26 2019	(r349449)
> +++ head/contrib/ipfilter/tools/ipmon.c	Thu Jun 27 02:43:30 2019	(r349450)
> @@ -1438,8 +1438,11 @@ printipflog:
>  static void usage(prog)
>  	char *prog;
>  {
> -	fprintf(stderr, "%s: [-NFhstvxX] [-f <logfile>]\n", prog);
> -	exit(1);
expected

> +	fprintf(stderr, "Usage: %s [ -abDFhnpstvxX ] [ -B <binary-logfile> ] [ -C <config-file> ]\n"
> +		"\t[ -f <device> ] [ -L <facility> ] [ -N <device> ]\n"
> +		"\t[ -o [NSI] ] [ -O [NSI] ] [ -P <pidfile> ] [ -S <device> ]\n"
> +		"\t[ <filename> ]\n", prog);
> +	exit(-1);

Was it intentional to flip the exit code to -1?
Someones scripts might not be prepared for that.

>  }

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201906270301.x5R31sLH057763>