Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Oct 2007 00:26:58 GMT
From:      Oleg Pudeyev <oleg.pudeyev@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/117284: [patch] graphics/feh: remove dependency on shells/bash
Message-ID:  <200710180026.l9I0QwK6026095@www.freebsd.org>
Resent-Message-ID: <200710180030.l9I0U1uI017096@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         117284
>Category:       ports
>Synopsis:       [patch] graphics/feh: remove dependency on shells/bash
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 18 00:30:01 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Oleg Pudeyev
>Release:        6.2-RELEASE
>Organization:
>Environment:
FreeBSD kappa.universe 6.2-RELEASE FreeBSD 6.2-RELEASE #2: Wed Jul 18 01:25:26 EDT 2007     root@kappa.universe:/build/src/sys/i386/compile/KAPPA  i386
>Description:
Attached patch removes dependency of graphics/feh on shells/bash. Only one installed shell script (gen_cam_menu.sh) appears to use bash, and nothing in that shell script seems to require bash. The patch replaces /bin/bash reference with /bin/sh and removes bash from RUN_DEPENDS.

I have also filed a ticket with feh developers at http://linuxbrit.co.uk/feh/ticket/34.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/graphics/feh/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- Makefile	19 May 2007 20:08:59 -0000	1.24
+++ Makefile	18 Oct 2007 00:19:37 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	feh
 PORTVERSION=	1.3.4
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics
 MASTER_SITES=	http://linuxbrit.co.uk/downloads/
 
@@ -15,7 +15,6 @@
 COMMENT=	An image viewer that utilizes Imlib2
 
 LIB_DEPENDS=	giblib.1:${PORTSDIR}/graphics/giblib
-RUN_DEPENDS=	bash:${PORTSDIR}/shells/bash
 
 USE_X_PREFIX=	yes
 USE_PERL5=	yes
@@ -36,7 +35,7 @@
 	@${PERL} -pi.bak -e \
 		's|-man install-docsDATA|-man|g' ${WRKSRC}/Makefile.in
 	@${PERL} -pi.bak -e \
-		's|^#!/bin|#!${LOCALBASE}/bin|g' ${WRKSRC}/cam/gen_cam_menu.sh
+		's|^#!/bin/bash|#!/bin/sh|g' ${WRKSRC}/cam/gen_cam_menu.sh
 	@${PERL} -pi.bak -e \
 		's|^LDFLAGS.*$$|LDFLAGS = \@LDFLAGS\@|g ; \
 		 s|-I/usr/X11R6/include||g ; \


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710180026.l9I0QwK6026095>