Date: Tue, 22 Jul 2014 12:48:08 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 192032] New: [PATCH] savecore(8): Distinguish getbounds() errors; don't leak a FILE* Message-ID: <bug-192032-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192032 Bug ID: 192032 Summary: [PATCH] savecore(8): Distinguish getbounds() errors; don't leak a FILE* Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: conrad.meyer@isilon.com Created attachment 144872 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=144872&action=edit (apply with -p1 in src/) Minor: when fgets(3) fails in getbounds(), check for EOF and if not EOF, print strerror(3). Also, don't leak fp during non-error return (trivial since savecore(8) is not a long-running process anyway). Sponsored by: EMC / Isilon storage division -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192032-8>