Date: Tue, 19 Jul 2016 21:49:47 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Ed Maste <emaste@freebsd.org> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Call for Testing: Switching back to our BSD licensed dtc(1) Message-ID: <20160719214947.ae2edc38528eaaab1388403f@bidouilliste.com> In-Reply-To: <CAPyFy2A71h5WYXR4cNoDRZ-sB2FWmJva6FFNX4jtSZqH=JxpMg@mail.gmail.com> References: <CAPyFy2A71h5WYXR4cNoDRZ-sB2FWmJva6FFNX4jtSZqH=JxpMg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello,
I've just tried bsd dtc on all arm dts that we have.
It doesn't seems to handle multiple include directories.
Here is how to reproduce :
$ export SRCROOT=/path/to/fbsd/src
$ export MACHINE=arm
$ cd $SRCROOT/sys/boot/fdt/dts/arm
$ $SRCROOT/sys/tools/fdt/make_dtb.sh $SRCROOT/sys
beaglebone-black.dts . converting beaglebone-black.dts
-> ./beaglebone-black.dtb Unable to open file
'/home/elbarto/Work/freebsd/freebsd.git//sys/boot/fdt/dts/arm/am33xx-clocks.dtsi'.
No such file or directory Unable to open file
'/home/elbarto/Work/freebsd/freebsd.git//sys/boot/fdt/dts/arm/tps65217.dtsi'.
No such file or directory
Both dtsi files are include with /include/ (i.e. not handled by cpp).
make_dtb.sh specify : -i $S/boot/fdt/dts/${MACHINE} -i
$S/gnu/dts/${MACHINE}, it looks like the second one isn't added to the
list.
Trying tegra124-jetson-tk1-fbsd.dts give this :
converting tegra124-jetson-tk1-fbsd.dts
-> /tmp/bsd_dtb//tegra124-jetson-tk1-fbsd.dtb Error on line 1214:
Expected node name interrupt-affinity = <&{/cpus/cpu@0}>,
^
Error on line 1214: Expected ; at end of property
interrupt-affinity = <&{/cpus/cpu@0}>,
^
Failed to parse tree. Unhappy face!
Cheers,
On Tue, 19 Jul 2016 15:12:02 -0400
Ed Maste <emaste@freebsd.org> wrote:
> dtc(1) is the Device Tree Compiler, used for embedded builds. We have
> two versions of dtc(1) in the FreeBSD tree: a GPLv2 one from
> https://git.kernel.org/cgit/utils/dtc/dtc.git and a BSD licensed one
> in https://svn.freebsd.org/base/head/usr.bin/dtc.
>
> We switched back to the GPL one since device tree files in the most
> recent import required features not available in our own at the time.
> However, as of r292876 the BSD licensed dtc(1) is functional and we
> should be able to switch back to it.
>
> I would encourage embedded users (primarily ARM boards) to test with
> WITHOUT_GPL_DTC in /etc/src.conf and report their success or failure.
>
> -Ed
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
--
Emmanuel Vadot
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160719214947.ae2edc38528eaaab1388403f>