Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Sep 2021 16:35:21 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: e961e7dc00ab - stable/13 - genassym.sh: Fix two minor issues found by shellcheck
Message-ID:  <202109121635.18CGZLcV074018@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=e961e7dc00abfa7baaf637389cdde42db4b0e2fa

commit e961e7dc00abfa7baaf637389cdde42db4b0e2fa
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2021-07-28 19:42:29 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2021-09-12 15:56:14 +0000

    genassym.sh: Fix two minor issues found by shellcheck
    
    o Remove redunant $ in $(( )) expression.
    o Quote arg passed to work so paths with spaces, etc will work.
    
    MFC After:              2 weeks
    Reviewed by:            kib
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D31335
    
    (cherry picked from commit 46dd3ef0338ba2ad24d05bab2a614410cf17b017)
---
 sys/kern/genassym.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sys/kern/genassym.sh b/sys/kern/genassym.sh
index 0374c8844b9a..999090f22d0e 100644
--- a/sys/kern/genassym.sh
+++ b/sys/kern/genassym.sh
@@ -57,7 +57,7 @@ do
 	*)	usage;;
 	esac
 done
-shift $(($OPTIND - 1))
+shift $((OPTIND - 1))
 case $# in
 1)	;;
 *)	usage;;
@@ -65,8 +65,8 @@ esac
 
 if [ "$use_outfile" = "yes" ]
 then
-	work $1  3>"$outfile" >&3 3>&-
+	work "$1"  3>"$outfile" >&3 3>&-
 else
-	work $1
+	work "$1"
 fi
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202109121635.18CGZLcV074018>