Date: Mon, 05 Oct 2009 09:30:28 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Alan Cox <alc@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r197750 - head/sys/vm Message-ID: <4AC9F4F4.4030008@FreeBSD.org> In-Reply-To: <200910041853.n94IrAf7082338@svn.freebsd.org> References: <200910041853.n94IrAf7082338@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alan Cox wrote: > Author: alc > Date: Sun Oct 4 18:53:10 2009 > New Revision: 197750 > URL: http://svn.freebsd.org/changeset/base/197750 > > Log: > Align and pad the page queue and free page queue locks so that the linker > can't possibly place them together within the same cache line. > > MFC after: 3 weeks > > Modified: > head/sys/vm/vm_page.c > head/sys/vm/vm_page.h > > Modified: head/sys/vm/vm_page.c > ============================================================================== > --- head/sys/vm/vm_page.c Sun Oct 4 17:22:51 2009 (r197749) > +++ head/sys/vm/vm_page.c Sun Oct 4 18:53:10 2009 (r197750) > @@ -135,8 +135,8 @@ __FBSDID("$FreeBSD$"); > */ > > struct vpgqueues vm_page_queues[PQ_COUNT]; > -struct mtx vm_page_queue_mtx; > -struct mtx vm_page_queue_free_mtx; > +struct vpglocks vm_page_queue_lock; > +struct vpglocks vm_page_queue_free_lock; I think you can do this by just: struct mtx vm_page_queue_mtx __aligned(CACHE_LINE_SIZE); without the need for a wrapper structure. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AC9F4F4.4030008>