Date: Tue, 18 Nov 2003 16:46:24 -0800 (PST) From: Nate Lawson <nate@root.org> To: Mark Murray <markm@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_intr.c Message-ID: <20031118163849.S65744@root.org> In-Reply-To: <20031119111015.E5018@gamplex.bde.org> References: <200311181435.hAIEZhtY048135@repoman.freebsd.org> <20031119111015.E5018@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 19 Nov 2003, Bruce Evans wrote: > On Tue, 18 Nov 2003, Mark Murray wrote: > > > markm 2003/11/18 06:35:43 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_intr.c > > Log: > > Hackfix to patch around a kernel panic I introduced. Real fix to > > follow. In the meanwhile, we are not harvesting interrupt entropy. > > > > Approved by: re (jhb) > > The correct fix is approximately to back out the changes to the > harvester. It needs to use preallocated storage like it used to since > it is called from nearly the lowest level of interrupt handling when > neither malloc() nor sleep locks may be used. Using preallocated storage > also simplifies the locking. I agree. Separating the buffer into per-source buffers does not require changing from a ring buffer to a malloc/FIFO model. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031118163849.S65744>