Date: Fri, 15 Dec 2006 11:19:39 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: hselasky@c2i.net Cc: perforce@freebsd.org Subject: Re: PERFORCE change 111622 for review Message-ID: <20061215.111939.1723236289.imp@bsdimp.com> In-Reply-To: <200612150954.58930.hselasky@c2i.net> References: <200612131032.kBDAWXcE034886@repoman.freebsd.org> <20061214.222631.-345496069.imp@bsdimp.com> <200612150954.58930.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200612150954.58930.hselasky@c2i.net>
Hans Petter Selasky <hselasky@c2i.net> writes:
: On Friday 15 December 2006 06:26, M. Warner Losh wrote:
: > In message: <200612131032.kBDAWXcE034886@repoman.freebsd.org>
: >
: > Hans Petter Selasky <hselasky@freebsd.org> writes:
: > : http://perforce.freebsd.org/chv.cgi?CH=111622
: > :
: > : Change 111622 by hselasky@hselasky_mini_itx on 2006/12/13 10:31:33
: > :
: > : Compile fix: Add missing dependency, vnode_if.h.
: > :
: > : Affected files ...
: > :
: > : .. //depot/projects/usb/src/sys/modules/ugen/Makefile#2 edit
: > :
: > : Differences ...
: > :
: > : ==== //depot/projects/usb/src/sys/modules/ugen/Makefile#2 (text+ko) ====
: > :
: > : @@ -3,6 +3,6 @@
: > : .PATH: ${.CURDIR}/../../dev/usb
: > :
: > : KMOD= ugen
: > : -SRCS= bus_if.h device_if.h opt_usb.h ugen.c usbdevs.h
: > : +SRCS= bus_if.h device_if.h opt_usb.h ugen.c usbdevs.h vnode_if.h
: >
: > What does the usb driver need vnode_if.h for? There was an old
: > dependency on it, but it was elimianted.
: >
:
: I see that <sys/vnode.h> does no longer include "vnode_if.h". I added this
: bascially to get the code compiling on some older systems, where "vnode_if.h"
: is still included by <sys/vnode.h>. I will revert this, and keep the
: "vnode_if.h" patch in my SVN repo only.
sys/vnode.h shouldn't be included by drivers. That's why we
eliminated this dependency.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061215.111939.1723236289.imp>