Date: Tue, 20 Oct 2015 11:26:00 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Jan Beich <jbeich@vfemail.net>, Lars Engels <lme@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r399705 - head/net-mgmt/aircrack-ng Message-ID: <7D8DC2B6B35EA3356CFE4530@atuin.in.mat.cc> In-Reply-To: <oafu-r9mo-wny@vfemail.net> References: <201510191805.t9JI5mEP085148@repo.freebsd.org> <oafu-r9mo-wny@vfemail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========26D2D04CE8DC7C71677F==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
+--On 19 octobre 2015 20:33:35 +0200 Jan Beich <jbeich@vfemail.net> wrote:
| Lars Engels <lme@FreeBSD.org> writes:
|
|> +INSTALL_TARGET= strip install
| [...]
|> -post-install:
|> - @${STRIP_CMD} ${BIN_FILES:S,^,${STAGEDIR}${PREFIX}/bin/,} \
|> - ${SBIN_FILES:S,^,${STAGEDIR}${PREFIX}/sbin/,}
|
| This always strips the binaries, even for WITH_DEBUG=1. The magic for
| INSTALL_TARGET in bsd.port.mk only works with default automake target.
|
| Index: net-mgmt/aircrack-ng/Makefile
| ===================================================================
| --- net-mgmt/aircrack-ng/Makefile (revision 399707)
| +++ net-mgmt/aircrack-ng/Makefile (working copy)
| @@ -18,7 +18,7 @@ CPE_VERSION= ${DISTVERSION:C/-.*//}
| CPE_UPDATE= ${DISTVERSION:C/^[^-]*$//:C/.*-//}
| DOS2UNIX_FILES= src/osdep/byteorder.h
| MAKE_ARGS= experimental=true libnl=false prefix=${PREFIX}
| -INSTALL_TARGET= strip install
| +INSTALL_TARGET= ${STRIP:S/-s/strip/} install
| USE_OPENSSL= yes
|
| OPTIONS_DEFINE= PCRE SQLITE
This is harder to understand, if you don't know what STRIP is for, or what
it contains, it does not make a lot of sense, the previous way was better,
I feel.
--
Mathieu Arnold
--==========26D2D04CE8DC7C71677F==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJWJgioXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IUKAP/1R6pkwb5Yi6VlWNr6CbUe6H
FH7WWMHNNgIUccYVPk71sN93VUuk6a9NaOKXjBtKAXleaX3FdxSiE0u6g3T02i7C
TQjAaYd1xTMxpHFq32ijlG0pNSCHPaq4WN2FJrabp7l1JDjIDVtsgCIKIPVR0Gvc
K7DgX1fWA02rriNH7VNH/Y0NupfO7NlArkmXwimIl/UMp0XItgQaU3AEIfiwGY5c
rk0eTO9zvANP1iM25h1zLJb0wWjB2Jw/OBq0GC6T1S9hYzbo/k602oZS3Z0PpTKd
G9P2xc68/ac9cpVqs3odYOLucNANlP6HHVy4W2lAsWUBRP7Im8B3T0ug00+pT7Bu
7qk57aeF/1lOEeoILwJDphbt6sGaG8Dib07E4ZL07mZwgsS3/9GlFUQ6GtEkrR7B
cjgXBSFPRFPl7P1aaAIKwqK+9aotGtdCzZXgvhBcdjdXNuAVTTvrfFI8vQXv21f+
/WxRoO0Z7I1KyduO15ZnGKlARhVAJwxhrJwZm17ENpKq1zvEYzB3GocE2GH1ATCQ
x8/ytVVx6ueTVHAoaY3dwEQ6SU/6LqSc2SZc8BED+YCeEZaIJt8wdG802aWKWTED
0lNbCn3zRrMMYID0iRcFBge4IbJU66eNX4+ajZbGU/bgdJklYw2l5u/lAuZDFnwM
cCXo6/1P2IXKUZ0jUm8C
=UEQw
-----END PGP SIGNATURE-----
--==========26D2D04CE8DC7C71677F==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7D8DC2B6B35EA3356CFE4530>