Date: Fri, 21 Sep 2001 16:24:30 -0700 (PDT) From: Julian Elischer <julian@elischer.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sys_generic.c Message-ID: <Pine.BSF.4.21.0109211616560.37053-100000@InterJet.elischer.org> In-Reply-To: <200109212206.f8LM6MF13902@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
huh? in a 1:1 world, the p_flag word is 32 x 4 bits long and happens to be non contiguous, but since they are all in the proc structure, they are still covered by the proc lock, are they not? All the bits in td_flags originally came from p_flag so the proc lock covers them all. If it was using the proc loc before I left it that way.. If it used the sched lock I left it that way. I don't understand why you say that this has changed, because I didn't change that. On Fri, 21 Sep 2001, John Baldwin wrote: > jhb 2001/09/21 15:06:22 PDT > > Modified files: > sys/kern sys_generic.c > Log: > The P_SELECT flag was moved from p->p_flag to td->td_flags, but p_flag > was locked by the proc lock and td_flags is locked by the sched_lock. > The places that read, set, and cleared TDF_SELECT weren't updated, so they > read and modified td_flags w/o holding the sched_lock, meaning that they > could corrupt the per-thread flags field. As an immediate band-aid, > grab sched_lock while reading and manipulating td_flags in relation to > TDF_SELECT. This will probably be cleaned up some later on. > > Revision Changes Path > 1.82 +21 -3 src/sys/kern/sys_generic.c > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0109211616560.37053-100000>