Date: Thu, 9 May 2002 12:23:03 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/sysctl sysctl.c Message-ID: <20020509082303.GA2131@nagual.pp.ru> In-Reply-To: <20020509151407.D3794-100000@gamplex.bde.org> References: <20020509040953.GA894@nagual.pp.ru> <20020509151407.D3794-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 09, 2002 at 15:25:11 +1000, Bruce Evans wrote: > > > > Revision Changes Path > > > > 1.45 +1 -1 src/sbin/sysctl/sysctl.c > > > > > > This overruns the buffer in the (unlikely) even that sysctl(3) returned a > > > full buffer. > > > > Do you saw j += j there? Buffer is doubled (unless I misunderstand this > > thing). > > Yes; that is why I wrote that the even[t] is unlikely. We double the buffer > size in case the name expands underneath us. If the name actually expands > by a full factor of 2, we overrun the buffer. In any case this problem not with my commit :-) -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020509082303.GA2131>