Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 Sep 2003 18:44:30 +0700
From:      Alexey Dokuchaev <danfe@nsu.ru>
To:        Matt <matt@xtaz.co.uk>
Cc:        Harald Schmalzbauer <h@schmalzbauer.de>
Subject:   Re: [patch] FreeBSD Port: nvidia-driver-1.0.4365
Message-ID:  <20030903114430.GB20427@regency.nsu.ru>
In-Reply-To: <3F55CD2C.7070407@xtaz.co.uk>
References:  <200309031302.01977@harrymail> <20030903110830.GR41860@freebsd.org.ru> <3F55CD2C.7070407@xtaz.co.uk>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 03, 2003 at 12:14:52PM +0100, Matt wrote:
> Sergey A. Osokin wrote:
> 
> >On Wed, Sep 03, 2003 at 01:01:55PM +0200, Harald Schmalzbauer wrote:
> >
> >>with today's -current the nvidia port failed to compile.
> >>With a bit luck I found that there seems to be a misstype in the 
> >>src/nvidia_sysctl.c. I'm no programmer so I don't know if this has 
> >>changed recently or if it has always been an error but the old gcc didn't 
> >>complain (I think the former)
> >>
> >>To make it short: I created patch.aa in files and it works fine with 
> >>today's -current.
> >>
> >>I don't have any -stable so if it is only an 5.x issue there someone 
> >>shuld correct the port to make the patch OS-dependent.
> >>
> >>Please commit the patch.
> >
> >
> >Hmm, where is the patch?
> >danfe: please review the patch :-)
> >
> 
> A constant in one of the kernel header file seems to have been renamed. 
> Change PCIR_HEADERTYPE to PCIR_HDRTYPE in nvidia_sysctl.c and all will 
> be well.
> 
> There is a pr for this which is ports/56157.

I'm aware of this.  However, people seem to be having other problems
with nvidia-driver on -current; they have sent patches for those as
well.  I'll review all of patches and deal with issues during very next
day or two.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030903114430.GB20427>