Date: Sun, 14 Apr 2013 13:54:25 +0100 (BST) From: Chris Rees <crees@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/177854: [PATCH] Fix port: graphics/libgphoto2 NLS detection Message-ID: <20130414125425.2C5921F939@pegasus.bayofrum.net> Resent-Message-ID: <201304141300.r3ED00Qw059067@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 177854
>Category: ports
>Synopsis: [PATCH] Fix port: graphics/libgphoto2 NLS detection
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Apr 14 13:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Chris Rees
>Release: FreeBSD 9.1-STABLE amd64
>Organization:
>Environment:
System: FreeBSD pegasus.bayofrum.net 9.1-STABLE FreeBSD 9.1-STABLE #0 r247189: Sat Feb 23 15:20:18 GMT 2013 root@pegasus.bayofrum.net:/usr/obj/usr/home/crees/workspace/src/stable/9/sys/PEGASUS amd64
>Description:
WITHOUT_NLS is defined in bsd.options.mk nowadays, when ${PORT_OPTIONS:MNLS} implies it.
Of course, without bsd.port.options.mk included, this doesn't take effect, and the build actually fails on a non-NLS system.
>How-To-Repeat:
>Fix:
Include bsd.port.options.mk
While here, use OPTIONSng
--- patch.txt begins here ---
Index: Makefile
===================================================================
--- Makefile (revision 315798)
+++ Makefile (working copy)
@@ -25,7 +25,9 @@
MAN3= libgphoto2.3 libgphoto2_port.3
-.if defined(WITHOUT_NLS)
+.include <bsd.port.options.mk>
+
+.if ! ${PORT_OPTIONS:MNLS}
CONFIGURE_ARGS+= --disable-nls
PLIST_SUB+= NLS="@comment "
USE_ICONV= yes
--- patch.txt ends here ---
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130414125425.2C5921F939>