Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Oct 2000 16:17:03 -0700
From:      Paul Saab <paul@mu.org>
To:        David Greenman <dg@root.com>
Cc:        Paul Saab <ps@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/ata ata-disk.c src/sys/kern kern_shutdown.c src/sys/sys systm.h
Message-ID:  <20001013161703.A68869@elvis.mu.org>
In-Reply-To: <200010132309.QAA11943@implode.root.com>; from dg@root.com on Fri, Oct 13, 2000 at 04:09:57PM -0700
References:  <200010132149.OAA93124@freefall.freebsd.org> <200010132309.QAA11943@implode.root.com>

next in thread | previous in thread | raw e-mail | index | archive | help
David Greenman (dg@root.com) wrote:
> >ps          2000/10/13 14:49:20 PDT
> >
> >  Modified files:
> >    sys/dev/ata          ata-disk.c 
> >    sys/kern             kern_shutdown.c 
> >    sys/sys              systm.h 
> >  Log:
> >  Do not allocate a callout for all crashdumps, not just when you panic.
> 
>    Did you intend for this to be a double-negative?

No.. I noticed I made that mistake after I committed it.. *sigh*.
What happened before is if you did a call dumpsys or call boot(0x104) from
ddb, the ata driver would allocate a callout for every 4k it wrote and
you would eventually run out of callout entries and panic during a dump.

-- 
Paul Saab
Technical Yahoo
paul@mu.org - ps@yahoo-inc.com - ps@freebsd.org
Do You .. uhh .. Yahoo!?


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001013161703.A68869>