Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 12 Jun 2003 00:44:51 -0700
From:      Kris Kennaway <kris@obsecurity.org>
To:        Kris Kennaway <kris@obsecurity.org>
Cc:        current@freebsd.org
Subject:   Re: adsl/pppoe no longer connecting on 5.1
Message-ID:  <20030612074451.GA39145@rot13.obsecurity.org>
In-Reply-To: <20030612073836.GA39115@rot13.obsecurity.org>
References:  <200306112248.AA655556764@141.com> <20030612045022.GA36033@rot13.obsecurity.org> <20030612051812.GQ48387@mail.evip.pl> <20030612073836.GA39115@rot13.obsecurity.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--ReaqsoxgOBHFXBhH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jun 12, 2003 at 12:38:36AM -0700, Kris Kennaway wrote:

> Okay, it looks like alloca.S was broken.  My previous patch that
> increased the size of allocations was just a gratuitous difference
> with the inline version, and is not necessary.  Here's a fix that
> seems to get ppp to stop complaining.

Oops, forgot to remove the movl.

Index: alloca.S
===================================================================
RCS file: /usr/home/ncvs/src/lib/libc/i386/gen/alloca.S,v
retrieving revision 1.10
diff -u -r1.10 alloca.S
--- alloca.S	23 Mar 2002 02:44:18 -0000	1.10
+++ alloca.S	12 Jun 2003 07:41:45 -0000
@@ -50,7 +50,7 @@
 	addl	$3,%eax		/*  round up to next word */
 	andl	$0xfffffffc,%eax
 	subl	%eax,%esp
-	movl	%esp,%eax	/* base of newly allocated space */
+	leal    24(%esp), %eax	/* base of newly allocated space */
 	pushl	8(%ecx)		/* copy possible saved registers */
 	pushl	4(%ecx)
 	pushl	0(%ecx)

Kris

--ReaqsoxgOBHFXBhH
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (FreeBSD)

iD8DBQE+6C9yWry0BWjoQKURApC1AJ4wJ4D2eQWSnwfdC9rYGCya4w/8ngCghVoL
hcUQsFWA2j9HSpscoPzpSAI=
=fJBi
-----END PGP SIGNATURE-----

--ReaqsoxgOBHFXBhH--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030612074451.GA39145>