Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 19 Sep 2010 17:30:47 +0300
From:      Kostik Belousov <kostikbel@gmail.com>
To:        Ed Schouten <ed@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r212860 - head/sys/kern
Message-ID:  <20100919143047.GB2389@deviant.kiev.zoral.com.ua>
In-Reply-To: <201009191421.o8JELdNY004586@svn.freebsd.org>
References:  <201009191421.o8JELdNY004586@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help 

--BKMA2OjimIttCqMD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Sep 19, 2010 at 02:21:39PM +0000, Ed Schouten wrote:
> Author: ed
> Date: Sun Sep 19 14:21:39 2010
> New Revision: 212860
> URL: http://svn.freebsd.org/changeset/base/212860
>=20
> Log:
>   Ignore DCD handling on /dev/console entirely.
>  =20
>   This makes /dev/console more fail-safe and prevents a potential console
>   lock-up during boot.
>  =20
>   Discussed on:	stable@
>   Tested by:	koitsu@
>   MFC after:	1 week
>=20
> Modified:
>   head/sys/kern/tty.c
>=20
> Modified: head/sys/kern/tty.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/kern/tty.c	Sun Sep 19 13:49:02 2010	(r212859)
> +++ head/sys/kern/tty.c	Sun Sep 19 14:21:39 2010	(r212860)
> @@ -282,7 +282,8 @@ ttydev_open(struct cdev *dev, int oflags
> =20
>  	/* Wait for Carrier Detect. */
>  	if (!TTY_CALLOUT(tp, dev) && (oflags & O_NONBLOCK) =3D=3D 0 &&
> -	    (tp->t_termios.c_cflag & CLOCAL) =3D=3D 0) {
> +	    (tp->t_termios.c_cflag & CLOCAL) =3D=3D 0 &&
> +	    dev !=3D dev_console) {
>  		while ((ttydevsw_modem(tp, 0, 0) & SER_DCD) =3D=3D 0) {
>  			error =3D tty_wait(tp, &tp->t_dcdwait);
>  			if (error !=3D 0)
Shouldn't you always report CLOCAL for console then ?

--BKMA2OjimIttCqMD
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)

iEYEARECAAYFAkyWHpYACgkQC3+MBN1Mb4gzhQCg7k1qEYnTi0AHaBEysuKkvBzo
xgEAnj21FwfS0AVskjI0/DY/5HntZmTu
=zoAg
-----END PGP SIGNATURE-----

--BKMA2OjimIttCqMD--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100919143047.GB2389>