Date: Tue, 25 Jun 2019 10:29:11 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Kubilay Kocak <koobs@freebsd.org> Cc: "Tobias C. Berner" <tcberner@gmail.com>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505045 - head/sysutils/plasma5-ksysguard Message-ID: <20190625082911.GA63640@KGPE-D16> In-Reply-To: <8eab69dc-52bb-a187-6a30-565ae58f4512@FreeBSD.org> References: <201906241810.x5OIAu1h080487@repo.freebsd.org> <CAOshKtcPHHa4%2Bv2kL_aNKXzoXs1VkGw0nEAx3PkaArPJ6kCGzw@mail.gmail.com> <20190624194627.GB49520@ThinkPad-X200.g.anongoth.pl> <CAOshKtegUmUYfdnDNmt9wuk1cSC_z_qpz8td597zC4y3Dup_-w@mail.gmail.com> <20190624202703.GA68048@ThinkPad-X200.g.anongoth.pl> <8eab69dc-52bb-a187-6a30-565ae58f4512@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable To be honest, I fail to see the meaning of this flag. If it's not about approval, then what does this flag actually mean? Only th= at "I acknowledge that there's a problem"? Then maybe work-in-progress? As in, the maintainer is working on the fix. On 19-06-25 11:59:32, Kubilay Kocak wrote: >On 25/06/2019 6:27 am, Piotr Kubaj wrote: >> OK, for me maintainer-feedback entry means that the patch is accepted. >> >> When I wasn't a committer, I used to set maintainer-feedback to indicate >> that I accept the patch. When I send PR's nowadays, some maintainers >> also do that. >> >> On 19-06-24 21:54:56, Tobias C. Berner wrote: >>> I set maintainer feedback, because I, as the maintainer gave you the >>> feedback, that "I think this is wrong" :) >>> If I liked that patch, I would have set the patch-approved flag on it. >>> >>> >>> All that said, thanks for "fixing" it, but I still would prefer a real >>> fix, >>> that we can upstream rather than that. >>> >>> >>> mfg Tobias >>> >>> >>> On Mon, 24 Jun 2019 at 21:46, Piotr Kubaj <pkubaj@anongoth.pl> wrote: >>> >>>> Oh, I didn't use "implicit". Doesn't maintainer-feedback + mean that >>>> it's >>>> accepted? >>>> >>>> On 19-06-24 21:34:09, Tobias C. Berner wrote: >>>> >Moin moin >>>> > >>>> >Sorry, but I explicitely did not approve this :) so using implicit >>>> on it, >>>> >is a bit of a crappy move. >>>> > >>>> >mfg Tobias >>>> > >>>> >On Mon, 24 Jun 2019 at 20:11, Piotr Kubaj <pkubaj@freebsd.org> wrote: >>>> > >>>> >> Author: pkubaj >>>> >> Date: Mon Jun 24 18:10:55 2019 >>>> >> New Revision: 505045 >>>> >> URL: https://svnweb.freebsd.org/changeset/ports/505045 >>>> >> >>>> >> Log: >>>> >>=C2=A0=C2=A0 sysutils/plasma5-ksysguard: fix build with GCC-based ar= chitectures >>>> >> >>>> >>=C2=A0=C2=A0 Link with libinotify explicitly to fix linking on GCC >>>> architectures. >>>> >> >>>> >>=C2=A0=C2=A0 PR:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 238702 >>>> >>=C2=A0=C2=A0 Approved by:=C2=A0 tcberner (maintainer, mentor) >>>> >> >>>> >> Modified: >>>> >>=C2=A0=C2=A0 head/sysutils/plasma5-ksysguard/Makefile >>>> >> >>>> >> Modified: head/sysutils/plasma5-ksysguard/Makefile >>>> >> >>>> >> >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>> >>>> >> --- head/sysutils/plasma5-ksysguard/Makefile=C2=A0=C2=A0=C2=A0 Mon = Jun 24 >>>> 18:07:12 2019 >>>> >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (r505044) >>>> >> +++ head/sysutils/plasma5-ksysguard/Makefile=C2=A0=C2=A0=C2=A0 Mon = Jun 24 >>>> 18:10:55 2019 >>>> >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (r505045) >>>> >> @@ -23,5 +23,6 @@ OPTIONS_SUB=3D=C2=A0 yes >>>> >> >>>> >>=C2=A0 INOTIFY_DESC=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 Filesystem alteration notifications using >>>> inotify >>>> >>=C2=A0 INOTIFY_LIB_DEPENDS=3D=C2=A0=C2=A0 libinotify.so:devel/libino= tify >>>> >> +INOTIFY_LDFLAGS=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -linotify >>>> >> >>>> >>=C2=A0 .include <bsd.port.mk> > > >What could we (bugmeister) name the flag so that it was clear that > >a) The flag is about needing feedback >b) The flag has nothing to do with / does not mean approval? > > >--=20 >This message has been scanned for viruses and >dangerous content by MailScanner, and is >believed to be clean. > --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl0R21cACgkQelmbhSCD nJ2qZg/+I6v5LGzcaXpd6TwjTsORNg+TW3IU7c7iaEAmggdyMT0idDTvoNYqOoYu 0UqSYPBtfXPEHzu/P7ETzCnOULj0NaZtw7EihngaFw8V8Az/QDPmM8URSZj00FhD ziD98PFSgQl8KjzQBkm/Atj131+TXhLUcc4t41QG+S2NYQSBm+yPdjoD0ckJW1kI i8s7gjiZWr8S1sQBfCHMwImShnvM8Gsqh7IaeJuTSB0oN6xEB/H91ROSaoO9UfMU gGgIYPSkNxQTRQFOsIGCWUIHQDWU4khNuSDmFEjZvCzN7CHQvBNTQexWsMcfT4lB BSSyUr3gJUU5OJ1xy/PvLWn65bNcCkkI0GwLU6q2yMX2eRMWWIuMzx+uk4QBQcLO z87wQ/Tnwn5I5JYhsTfe7MHwFwTi2Qcpxxf9+3cc+l2TCGZbOW/5FjN7s/91L6O4 WWJrko5QZhN/C5BJe4boCoEZ3VcUa/BtRs9yo569JvKR/1sCnuXWNOdaRhvh+Y+i m0Zm3mu80m/mcuXA/IAFjjmGSKomkwpylb1VtZ5Q8pHCuVmMtfJ5c3/w7/anjcGX d/L/xW0Qn9g5em5FK0cc6QJ/B2BqDoxdkIGHryPBt1jaDEVMN3toQmAV3V1qv715 7t9cdynLOnD67arHU3Pv2pNmiEdch6SWsg7tQ7oF48WPlL2QAoo= =DQHH -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190625082911.GA63640>