Date: Tue, 6 Jun 2017 09:58:25 +0200 From: Miles Fertel <milesfertel@college.harvard.edu> To: Brooks Davis <brooks@freebsd.org> Cc: soc-status@freebsd.org Subject: Re: Week 1 Update: Mergesort Tests Message-ID: <CADoeuZ8T5ne1k5Cd8VWwXt%2BiyQRuab5Fo_gc5QU=XP_qP0oGVg@mail.gmail.com> In-Reply-To: <20170606004130.GC14665@spindle.one-eyed-alien.net> References: <CADoeuZ8S=Jxf7b9F7C8Hq5H9Tp95EFRQbXMf9BAWPm8Pan%2B1ZQ@mail.gmail.com> <20170606004130.GC14665@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Made it public! Here's the review: https://github.com/milesfertel/GSOC-Mergesort/pull/1/commits/9297e92f08a7f318ec3e6e2e2377d78bfa763dbf I'm not sure if you'll see the comments on the pull request unless you're logged in. Let me know if that's a problem. -Miles On Tue, Jun 6, 2017 at 2:41 AM, Brooks Davis <brooks@freebsd.org> wrote: > I got an invite from github, but even when I was definitely logged in, I > got 404 errors accessing it. > > As a practical matter, your repo needs to be public as that's part of the > terms from Google. > > -- Brooks > > On Mon, Jun 05, 2017 at 09:53:00AM -0400, Miles Fertel wrote: > > Hey Brooks, > > > > Just wanted to let you know that I've pushed my first week of work to the > > github repo and added you as a collaborator. I've submitted a pull > request > > from the dev branch to the master and started a review with a question or > > two. > > > > I've edited mergesort_test.c to have a good first implementation, > including > > tests for: > > > > - Trivial arrays > > - Sorted arrays > > - Partially sorted arrays > > - Randomly generated arrays > > - Arrays with char elements > > > > I've built this up on top of the previous implementation, so the Kyuafile > > is the same. I ran the implementation locally with atf and kyua and the > > current mergesort behaves as expected, succeeding all all tests except > for > > the small element test. When my improved algorithm is complete, that > should > > pass as well. > > > > Please let me know if there's anything I could improve. > > > > - Miles >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADoeuZ8T5ne1k5Cd8VWwXt%2BiyQRuab5Fo_gc5QU=XP_qP0oGVg>