Date: Thu, 4 Sep 2008 14:52:00 +0100 From: Rui Paulo <rpaulo@FreeBSD.org> To: Jeremie Le Hen <jeremie@le-hen.org> Cc: freebsd-hackers@FreeBSD.org Subject: Re: Creation of the NO_SSP build knob Message-ID: <20080904135200.GC31289@alpha.local> In-Reply-To: <20080904124653.GK72107@obiwan.tataz.chchile.org> References: <20080904124653.GK72107@obiwan.tataz.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 04, 2008 at 02:46:53PM +0200, Jeremie Le Hen wrote: > Hello, > > There is currently a knob to enable/disable SSP: WITH_SSP or > WITHOUT_SSP. WITH_SSP is the default on -CURRENT, so no one had to put > WITH_SSP= in src.conf(5). This has hidden the following bug so far: > > When buildworld is run with WITH_SSP= on command-line or in src.conf(5), > it fails immediately with the following message, because the toolchain > is built with WITHOUT_SSP: > > % "/usr/src/share/mk/bsd.own.mk", line 365: WITH_SSP and WITHOUT_SSP can't both be set. > > My leaning is to create an additional knob NO_SSP, much like > NO_CPU_CFLAGS, that could be set internally. However I'm not sure it > complies with the src.conf(5) policy. Any objection to the patch below? We already have something like that. WITHOUT_SENDMAIL= is expanded to MK_SENDMAIL=no. You may want to do the same for SSP and keep the convention of the variable names.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080904135200.GC31289>