Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Jan 2018 16:12:52 +0100
From:      Tobias Kortkamp <tobik@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r459753 - in head/deskutils: . freeplane freeplane/files
Message-ID:  <1516720372.2689994.1245262664.06EEC8C7@webmail.messagingengine.com>
In-Reply-To: <20180123141944.GB73049@FreeBSD.org>
References:  <201801231415.w0NEFuvx082953@repo.freebsd.org> <20180123141944.GB73049@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 23, 2018, at 15:19, Alexey Dokuchaev wrote:
> On Tue, Jan 23, 2018 at 02:15:56PM +0000, Tobias Kortkamp wrote:
> > New Revision: 459753
> > URL: https://svnweb.freebsd.org/changeset/ports/459753
> > 
> > Log:
> >   New port: deskutils/freeplane
> >   
> > Added: head/deskutils/freeplane/Makefile
> > ...
> > @@ -0,0 +1,35 @@
> > +# Created by: Lo??c Bartoletti <lbartoletti@tuxfamily.org>
> > +# $FreeBSD$
> 
> ASCII please.
> 
> > +# Install freeplane.sh with the right permission, link to it to bin/
> > +# and let it resolve the path to DATADIR automatically to avoid
> > +# patching it further.  For this to work it has to be a link to an
> > +# absolute path.
> > +	${INSTALL_SCRIPT} ${WRKSRC}/freeplane.sh ${STAGEDIR}${DATADIR}
> > +	${LN} -s ${DATADIR}/freeplane.sh ${STAGEDIR}${PREFIX}/bin/freeplane
> 
> Symlinks pointing to an absolute path are bad.
> 
> ./danfe

Can you please explain why they "are bad"?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1516720372.2689994.1245262664.06EEC8C7>