Date: Sun, 12 Feb 2017 15:17:03 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Jan Beich <jbeich@freebsd.org>, mmokhi@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r433881 - in head/sysutils: . lttng-tools lttng-tools/files lttng-ust lttng-ust/files Message-ID: <f4844f3b-bbae-9331-349f-b25ac98229fd@FreeBSD.org> In-Reply-To: <20170211160318.A6D1F3E33@freefall.freebsd.org> References: <20170211160318.A6D1F3E33@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--u1uduAhACLMrehK4lbwjxp05jl0IEJsEL
Content-Type: multipart/mixed; boundary="Jk0LQ1m4EN6JUhGuGgf3Wqej4GDxL7ibX";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Jan Beich <jbeich@freebsd.org>, mmokhi@FreeBSD.org,
ports-committers@freebsd.org, svn-ports-all@freebsd.org,
svn-ports-head@freebsd.org
Message-ID: <f4844f3b-bbae-9331-349f-b25ac98229fd@FreeBSD.org>
Subject: Re: svn commit: r433881 - in head/sysutils: . lttng-tools
lttng-tools/files lttng-ust lttng-ust/files
References: <20170211160318.A6D1F3E33@freefall.freebsd.org>
In-Reply-To: <20170211160318.A6D1F3E33@freefall.freebsd.org>
--Jk0LQ1m4EN6JUhGuGgf3Wqej4GDxL7ibX
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Le 11/02/2017 =C3=A0 17:03, Jan Beich a =C3=A9crit :
> Mahdi Mokhtari <mmokhi@FreeBSD.org> writes:
>
>> + char tmp_path[PATH_MAX];
>> ++#if defined(__FreeBSD__)
>> ++ const size_t HOST_NAME_MAX =3D sysconf(_SC_HOST_NAME_MAX);
>> ++#endif
>> + char hostname[HOST_NAME_MAX];
> [...]
>> + struct ltt_session {
>> + char name[NAME_MAX];
>> ++#if defined(__FreeBSD__)
>> ++ char hostname[256]; /* Local hostname. */
>> ++#else
>> + char hostname[HOST_NAME_MAX]; /* Local hostname. */
>> ++#endif
> Why do you mix constant and sysconf() usage?
This one is a struct definition, I do not think you can use sysconf() in =
it.
--=20
Mathieu Arnold
--Jk0LQ1m4EN6JUhGuGgf3Wqej4GDxL7ibX--
--u1uduAhACLMrehK4lbwjxp05jl0IEJsEL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJYoG5gXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85ImM4P/iFx51fEl8AqNbLOcRVte7V8
il1oPE0Z1srO0LeMHcpyzSEw1g8BLQ7ZQ33MMrVlfh+fsPZubSO0Q5jxxrBja2qc
wuuMl/LUbfNtPxrbcK0D1/DgnYBXVh1pGCg6pWISgg7vBpkabtqrpSNvtt+Wrjpf
5nc+SH94tM43QGSGyAq9809SBuN9aM4BUlerrNAkPm8kN/ACc2xm9SqLQvsLBtxY
zlFkH1KjBW72WzOhuREVwylR61JSVVzKlTmdiBQhrEtcytpS4KIupH5tX1oXYIEj
SHplbwHt3wBz/PXxXz1RaXhgIrJqes3E2Te0Dv6BgivhgUocAwJ4x/HkXAweTNzA
0HbSXqO90UohQH/qVNIs7upeyG7SwFyxI+qvsfFju4jBM6zte7io72B2QkATP+Pd
UpNLzvg74QyVdUXj3KZSI4wY6v9AzFf8wfqVFH9i1gvdcw/6OghHMydTTLJtzvUu
ynSWvjiOpfl0KlhZ6cg38V+hk4yDXqvWEyi78IWmmDr4QnhzUA7le5gTN16w/yRU
xThPqmwBZj8I9ND/a3HH46z5rAze2kT/cm0534JiikYMG32tCNi+OAop55uhwOqO
FIzY4e4m+cr4+wWsgBr5cKfeoKFmgVT9CWMRWKA5AYKS6m5HBZ4k88ZhCfHm1p0h
U/VWkbDGvTjpniyL3Ii5
=l+/E
-----END PGP SIGNATURE-----
--u1uduAhACLMrehK4lbwjxp05jl0IEJsEL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f4844f3b-bbae-9331-349f-b25ac98229fd>