Date: Fri, 14 Apr 2017 14:52:56 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Ngie Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <6B556967-35B0-4F4F-9F1E-C088F8D48C80@gmail.com> In-Reply-To: <1940104.87G28XVdqf@ralph.baldwin.cx> References: <201704141941.v3EJfmCW003347@repo.freebsd.org> <1940104.87G28XVdqf@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_D8477057-EBD8-4E0F-93BC-4449869DD05B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 14, 2017, at 2:40 PM, John Baldwin <jhb@freebsd.org> wrote: >=20 > On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: >> Author: ngie >> Date: Fri Apr 14 19:41:48 2017 >> New Revision: 316938 >> URL: https://svnweb.freebsd.org/changeset/base/316938 >>=20 >> Log: >> savecore: fix space calculation with respect to `minfree` in = check_space(..) >>=20 >> - Use strtoll(3) instead of atoi(3), because atoi(3) limits the >> representable data to INT_MAX. Check the values received from >> strtoll(3), trimming trailing whitespace off the end to maintain >> POLA. >> - Use `KiB` instead of `kB` when describing free space, total space, >> etc. I am now fully aware of `KiB` being the IEC standard for 1024 >> bytes and `kB` being the IEC standard for 1000 bytes. >=20 > I will just rant lightly that no one actually uses this in the real = world. >=20 > Good lucking finding a "16 GiB" DIMM on crucial.com = <http://crucial.com/>; or a 4Kin drive. A > kilobyte is a power of 2. The End. >=20 > (Next up we'll have to rename 4k displays to > 4k<insert arbitrary and unrelated letter here>) https://media0.giphy.com/media/7rj2ZgttvgomY/giphy.gif = <https://media0.giphy.com/media/7rj2ZgttvgomY/giphy.gif>; :P. -Ngie --Apple-Mail=_D8477057-EBD8-4E0F-93BC-4449869DD05B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJY8US5AAoJEPWDqSZpMIYVCfUP/3wA5+5dTcBrRjYxgWZQ2o1X RRumpB5eNc12qs5dz64H3gpPdFYfaAqop0EGXWX/wJxS/8SpJVV5PEOMy2pBH7ag 8L33dfRJAh7UxeC1MM8ms0q7TsP7cIRXcYr+cAjL+n/R+1u5n8AkIiTJKX64bdBl HSo6CLpRT8UrkHTPXPSGYx014D3hU/YOY1TwuzOm70I1x4uqQl1oxv3hSCSeOlWW OBAaxuIRO8O2+6GYf/cPQZsfX2GDdlLWls/9nv47CRC7JD/AcksYaCVm2X8WA4nj czN1Dwtm60aPjFAltfChgi8m+yedJD36BvfT0WAm1eL1ZW7qYN6ATjS1HaWpuUnk Tcg1O/TMB8StpdamzI5TCXgANS2Xw45/IB9NAEHGrqohztxX6CHfudIrPpHWCOil 3gDt54YlNlPSeAFDu+6dA+/W3CqtIo75DufPVFutVAhmZFIOaS7IFswTqIWzM/d4 KXKle7ViKyT+KnGHuolHMpmA0+acf9HVFN0zQLNYVnCXwk9vWE5knKNymg7YkfJZ 5yJndqZQg+02RcH8rJoJjQ2DhflItAJQvfPI4c1QueOPHHMCCLrb9UkHkRSos8Np B8lgFHoXAxzybVAjweqr1R3nNIiJPH78niD9ZLhftDQHOI/izNvekT0Gb6ytFeYE iIslnKaBhFyHx6wog75J =eVXV -----END PGP SIGNATURE----- --Apple-Mail=_D8477057-EBD8-4E0F-93BC-4449869DD05B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6B556967-35B0-4F4F-9F1E-C088F8D48C80>