Date: Wed, 11 Feb 2009 22:15:38 +0000 (UTC) From: Sam Leffler <sam@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r188499 - head/sys/dev/ath/ath_hal/ar5416 Message-ID: <200902112215.n1BMFcFP037452@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: sam Date: Wed Feb 11 22:15:37 2009 New Revision: 188499 URL: http://svn.freebsd.org/changeset/base/188499 Log: gcc 4.3.2 examines getLowerUpperIndex() and concludes that it's not guaranteed to initialize its two last arguments. Therefore, there is a warning in the subsequent caller ar5416FillVpdTable(), which doesn't initialize those arguments. Change getLowerUpperIndex() to assign values to indexL and indexR even in the case of assertion failure. Submitted by: Pavel Roskin <proski@gnu.org> Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_reset.c Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_reset.c ============================================================================== --- head/sys/dev/ath/ath_hal/ar5416/ar5416_reset.c Wed Feb 11 20:36:17 2009 (r188498) +++ head/sys/dev/ath/ath_hal/ar5416/ar5416_reset.c Wed Feb 11 22:15:37 2009 (r188499) @@ -2710,6 +2710,7 @@ getLowerUpperIndex(uint8_t target, uint8 } } HALASSERT(0); + *indexL = *indexR = 0; return AH_FALSE; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902112215.n1BMFcFP037452>