Date: Thu, 30 Jan 2014 11:48:57 -0700 From: Warner Losh <imp@bsdimp.com> To: Adrian Chadd <adrian@freebsd.org> Cc: FreeBSD Net <freebsd-net@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: (removing mbuf flowid setup in flowtable.c) Message-ID: <87746AA8-4759-4302-883C-25CDAC95C322@bsdimp.com> In-Reply-To: <CAJ-Vmokh7AZdW3_G3CXDVzRfWm3EVz9kUeOWvHzr%2BG4SyNRyYg@mail.gmail.com> References: <CAJ-Vmokh7AZdW3_G3CXDVzRfWm3EVz9kUeOWvHzr%2BG4SyNRyYg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 30, 2014, at 11:40 AM, Adrian Chadd wrote: > On 30 January 2014 07:18, Adrian Chadd <adrian@freebsd.org> wrote: >> Hi, >>=20 >> I'd like to disable the code in flowtable.c that assigns the mbuf = flowid. >>=20 >> I'd like to ensure that any mbuf flowid that's set is (eventually) >> going to be consistently toeplitz in the future (to match what NICs >> are doing on the RX side) and this may cause the flowid to be set to >> something completely different. >>=20 >> I've only done some light production testing with this so far, to no >> visible ill effects. >>=20 >> What do people think? >=20 > Someone pointed out privately that doing this would mean that UDP > flows without flow ids would suddenly not have flowids any longer and > thus wouldn't use multiple output queues. >=20 > So, I'll leave this alone for now until I can import the toeplitz hash > code into -HEAD and add an option to tag outbound udp frames with this > particular flowid hash. toeplitz is a funky kind of matrix, according to google. What does that = have to do with mbufs? :) Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87746AA8-4759-4302-883C-25CDAC95C322>