Date: Thu, 17 Jul 2008 06:10:03 GMT From: Alexey Dokuchaev <danfe@nsu.ru> To: freebsd-usb@FreeBSD.org Subject: Re: usb/117185: [umodem] [patch] Add support for UNION interface descriptor Message-ID: <200807170610.m6H6A3s5035951@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR usb/117185; it has been noted by GNATS. From: Alexey Dokuchaev <danfe@nsu.ru> To: bug-followup@FreeBSD.org, eugen@grosbein.pp.ru Cc: imp@bsdimp.com Subject: Re: usb/117185: [umodem] [patch] Add support for UNION interface descriptor Date: Thu, 17 Jul 2008 13:04:27 +0700 Apparently, GNATS does not handle attached files correctly (or maybe I have to name them differently), anyways. Here're direct links for both latest patch by Jeremie and RELENG_6 backport: http://freebsd.nsu.ru/patches/umodem-nokia.diff http://freebsd.nsu.ru/patches/umodem-nokia-releng6.diff Hans Petter Selasky <hselasky(at)c2i.net> raised a point about this part of the patch: > + if (restart) > + p = (uByte *)(restart) + restart->bLength; that maybe we "can add some extra range checks here. Remember the descriptors come from the device itself, and might be corrupt."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807170610.m6H6A3s5035951>