Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Sep 2001 17:07:47 -0700 (PDT)
From:      Julian Elischer <julian@elischer.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern sys_generic.c
Message-ID:  <Pine.BSF.4.21.0109211658090.37053-100000@InterJet.elischer.org>
In-Reply-To: <XFMail.010921160238.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
hmmm
ok
BEFORE KSE:

/* These flags are kept in p_flag. */
#define P_ADVLOCK       0x00001 /* Process may hold a POSIX advisory
lock. */
#define P_CONTROLT      0x00002 /* Has a controlling terminal. */
#define P_KTHREAD       0x00004 /* Kernel thread. */
#define P_NOLOAD        0x00008 /* Ignore during load avg calculations. */
#define P_PPWAIT        0x00010 /* Parent is waiting for child to
exec/exit. */
#define P_SELECT        0x00040 /* Selecting; wakeup/waiting danger. */
#define P_SUGID         0x00100 /* Had set id privileges since last
exec. */
#define P_SYSTEM        0x00200 /* System proc: no sigs, stats or
swapping. */
#define P_TRACED        0x00800 /* Debugged process being traced. */
#define P_WAITED        0x01000 /* Debugging process has waited for
child. */
#define P_WEXIT         0x02000 /* Working on exiting. */
#define P_EXEC          0x04000 /* Process called exec. */

AFTER KSE:

/* These flags are kept in p_flag. */
/* In a KSE world some go to a thread or a KSE (*)*/
#define P_ADVLOCK       0x00001 /* Process may hold a POSIX advisory
lock. */
#define P_CONTROLT      0x00002 /* Has a controlling terminal. */
#define P_KTHREAD       0x00004 /* Kernel thread. (*)*/
#define P_NOLOAD        0x00008 /* Ignore during load avg calculations. */
#define P_PPWAIT        0x00010 /* Parent is waiting for child to
exec/exit. */
#define P_SUGID         0x00100 /* Had set id privileges since last
exec. */
#define P_SYSTEM        0x00200 /* System proc: no sigs, stats or
swapping. */
#define P_TRACED        0x00800 /* Debugged process being traced. */
#define P_WAITED        0x01000 /* Debugging process has waited for
child. */
#define P_WEXIT         0x02000 /* Working on exiting. */
#define P_EXEC          0x04000 /* Process called exec. */
#define P_KSES          0x08000 /* Process is using KSEs. */

You are right.. I meant p_sflag,
and in that context, The signal flag did move.
It is however the only one.. luckily..

It does suggest to me that maybe it was mislocated origially :-)

I never 100% understood that flag...


On Fri, 21 Sep 2001, John Baldwin wrote:

> 
> On 21-Sep-01 Julian Elischer wrote:
> > huh?
> > 
> > in a 1:1 world, the p_flag word is 32 x 4 bits long and happens to be non
> > contiguous, but since they are all in the proc structure, they are still
> > covered by the proc lock, are they not? 
> > 
> > All the bits in td_flags originally came from p_flag so the proc lock
> > covers them all. If it was using the proc loc before I left it that way..
> > If it used the sched lock I left it that way.
> 
> No, they did _not_ all come from p_flag.  Most of them came from p_sflag.
> 
> TDF_SINTR, TDF_TIMEOUT, TDF_CVWAITQ, TDF_TIMOFAIL were all PS_* flags before
> KSE.
> 
> -- 
> 
> John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
> PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
> "Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0109211658090.37053-100000>