Date: Tue, 19 Jul 2016 23:53:35 -0700 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Randall Stewart <rrs@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303037 - head/sys/kern Message-ID: <20160720065335.GU1076@FreeBSD.org> In-Reply-To: <201607191831.u6JIVJWq007542@repo.freebsd.org> References: <201607191831.u6JIVJWq007542@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 19, 2016 at 06:31:19PM +0000, Randall Stewart wrote: R> Author: rrs R> Date: Tue Jul 19 18:31:19 2016 R> New Revision: 303037 R> URL: https://svnweb.freebsd.org/changeset/base/303037 R> R> Log: R> This reverts out Gleb's changes and adds three small R> fixes that I think closes up the races Gleb was R> looking for. This is running quite nicely in Netflix and R> now no longer causes TCP-tcb leaks. R> R> Differential Revision: 7135 Just to notice that I am completely pissed of by this commit war, that you started. I've been testing my changes properly, I gave people time to review my changes. You didn't. >From your explanation in other emails I see that you've been testing your changes with a version of FreeBSD that is a heavily modified FreeBSD 10, not 11. The new code you mixed with revert of mine, doesn't fix the problem observed. It fixes another problem that you imagined, which might exist, but isn't observed. We already discussed that and you didn't prove it wrong. Your change doesn't even revert my change completely. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160720065335.GU1076>