Date: Wed, 27 Feb 2013 18:58:55 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: David Naylor <naylor.b.david@gmail.com> Cc: svn-ports-head@freebsd.org, Michael Scheidell <scheidell@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r313059 - in head/net/yate: . files Message-ID: <20130227175855.GK16178@ithaqua.etoilebsd.net> In-Reply-To: <201302271857.54860.naylor.b.david@gmail.com> References: <201302271453.r1RErNSc090629@svn.freebsd.org> <20130227161442.GJ16178@ithaqua.etoilebsd.net> <201302271857.54860.naylor.b.david@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--6TC23+W66xmFESAX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 27, 2013 at 06:57:51PM +0200, David Naylor wrote: > Hi >=20 > On Wednesday, 27 February 2013 18:14:42 Baptiste Daroussin wrote: > > See remarks below > >=20 > > On Wed, Feb 27, 2013 at 02:53:23PM +0000, Michael Scheidell wrote: > > > -.if defined(NOPORTDOCS) > > > +.if ${PORT_OPTIONS:MDOCS} > >=20 > > Here this should be .if ! ${PORT_OPTIONS:MDOCS} >=20 > I thought `.if empty(PORT_OPTIONS:MDOCS)` is preferred[1]? Although I pr= efer=20 > your approach... >=20 > Regards >=20 > [1] https://wiki.freebsd.org/Ports/Options/OptionsNG There is no preference wiki says empty() while handbook says ! ${...} the r= eason for the handbook to say ! ${} is that it is among some people more consiste= nt.=20 I have no opinion on this :) regards, Bapt --6TC23+W66xmFESAX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlEuSV8ACgkQ8kTtMUmk6EwDSwCeJjIr3XlELtHI+JqOBM1+8XB9 B3wAn1SqueMMCqJaWsd1dXNU+yhXwemP =Flr2 -----END PGP SIGNATURE----- --6TC23+W66xmFESAX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130227175855.GK16178>