Date: Mon, 12 May 1997 21:00:42 -0700 From: David Greenman <dg@root.com> To: Bruce Evans <bde@zeta.org.au> Cc: freebsd-bugs@hub.freebsd.org Subject: Re: kern/3584: small cleanup to tcp_input.c Message-ID: <199705130400.VAA11983@implode.root.com> In-Reply-To: Your message of "Mon, 12 May 1997 20:00:01 PDT." <199705130300.UAA24238@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>The following reply was made to PR kern/3584; it has been noted by GNATS. > >From: Bruce Evans <bde@zeta.org.au> >To: FreeBSD-gnats-submit@freebsd.org, luigi@iet.unipi.it >Cc: Subject: Re: kern/3584: small cleanup to tcp_input.c >Date: Tue, 13 May 1997 12:54:55 +1000 > > > The TCP_REASS macro is defined two times, depending on the > > value of TCP_ACK_HACK. Since the macro is quite long, I think > > this definition is preferable > > Fine. > > > (and consistent with the > > convention for multiline macros in style(9) ). > > Aligned backslashes may be easier to read, but they are Kernal Abnormal > Form, especially in network code (see mbuf.h). Actually, I think TCP_ACK_HACK should just be killed altogether. It's a creation of mine that needs to die. -DG David Greenman Core-team/Principal Architect, The FreeBSD Project
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705130400.VAA11983>