Date: Tue, 18 Jun 2013 23:30:01 GMT From: Alex Stangl <alex@stangl.us> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/179637: [patch] ports-mgmt/portupdate-scan: add the "-a [date]" option Message-ID: <201306182330.r5INU1Tu042762@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/179637; it has been noted by GNATS.
From: Alex Stangl <alex@stangl.us>
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: ports/179637: [patch] ports-mgmt/portupdate-scan: add the "-a
[date]" option
Date: Tue, 18 Jun 2013 18:20:06 -0500
On Tue, Jun 18, 2013 at 07:07:48PM +0000, Edwin Groothuis wrote:
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
I basically agree with this patch, but would like to see changes
made to address a few issues:
1. Need to bump the version # in the Makefile.
2. Spacing inconsistent with existing code and extra space in usage line.
3. Instead of 3 lines to immediately exit, it'd be shorter and cleaner
to use:
last if $res <= $afterDate;
Should I submit an alternate patch?
Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306182330.r5INU1Tu042762>