Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Mar 2014 01:32:02 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Gerald Pfeifer <gerald@pfeifer.com>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r347964 - in head: . Mk Mk/Uses
Message-ID:  <20140313003202.GB90364@ithaqua.etoilebsd.net>
In-Reply-To: <alpine.LSU.2.11.1403122340060.1309@tuna.site>
References:  <201403120917.s2C9H6RL088610@svn.freebsd.org> <alpine.LSU.2.11.1403122340060.1309@tuna.site>

next in thread | previous in thread | raw e-mail | index | archive | help

--wzJLGUyc3ArbnUjN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 12, 2014 at 11:58:20PM +0100, Gerald Pfeifer wrote:
> On Wed, 12 Mar 2014, Baptiste Daroussin wrote:
> > Added: head/Mk/Uses/lha.mk
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > +# $FreeBSD$
> > +#
> > +# handle lha archives
>=20
> Looking at new committers and casual contributors who join in the future,=
=20
> this feels a bit brief.  What do you think about making this something=20
> like
>=20
>   Use this when a port's sources are in the lha archive format.
>=20
> ?  Are you approve me making this change?
>=20
> > Added: head/Mk/Uses/tar.mk
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > +# handle tar archives
> > +#
> > +# MAINTAINER: portmgr@FreeBSD.org
> > +#
> > +# Feature:	tar
> > +# Usage:	USES=3Dtar[:[xz|Z|bzip2|tgz]]
>=20
> For this cases, and others, what do you think of moving the
> MAINTAINER information towards the end of the comment block?
>=20
> I like my portmgrs ;-), but the actual information about what=20
> this file does feels more important.
>=20
> Do you approve me making this change across Mk/Uses/* per the patch
> below?
>=20
sure approved

regards,
Bapt

--wzJLGUyc3ArbnUjN
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlMg/IIACgkQ8kTtMUmk6EwcNQCfRJm+PCTKyDtwd1Klepzt7hB6
3xcAoKWo/fJJTg/zRKiPbCmduFjIYpu0
=kbX4
-----END PGP SIGNATURE-----

--wzJLGUyc3ArbnUjN--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140313003202.GB90364>