Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Feb 2019 10:06:51 -0800
From:      John Baldwin <jhb@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        rgrimes@freebsd.org, "Simon J. Gerraty" <sjg@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec
Message-ID:  <f917e2f2-67f5-e3f7-cb53-0768626b31c2@FreeBSD.org>
In-Reply-To: <20190226172358.GA67992@FreeBSD.org>
References:  <201902260617.x1Q6HOra098699@repo.freebsd.org> <201902260619.x1Q6Jjn2043418@pdx.rh.CN85.dnsmgr.net> <20190226134953.GB39566@FreeBSD.org> <34ecb52f-c89e-0d5e-594e-25b0d045d171@FreeBSD.org> <20190226172358.GA67992@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2/26/19 9:23 AM, Alexey Dokuchaev wrote:
> On Tue, Feb 26, 2019 at 09:12:11AM -0800, John Baldwin wrote:
>> On 2/26/19 5:49 AM, Alexey Dokuchaev wrote:
>>> On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote:
>>>> ...
>>>> Just a small nit, for future reference, from the template:
>>>>> Differential Revision:    https://reviews.freebsd.org/D###
>>>> (*full* phabric URL needed).
>>>
>>> IMHO we should just fix the scripts to accept D#### alone, without
>>> the URL.  We don't do that for PR (bugzilla) references, and the fact
>>> that we do for the phab is both needless and confusing.  Also, that
>>> URL might change one day while we could probably keep the old numbers
>>> if we move.
>>
>> It makes the review clickable in many mail clients which is very handy.
> 
> I understand that, but then again, we don't do that for PRs and people
> don't seem to complain.  Accepting D#### would make this all consistent
> and commit messages cleaner.  Arguably, if one likes to click the URLs
> in their mail client, why not configure the client to expand the URL in
> place?
> 
>> --
>> John Baldwin
>>
>> \x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a\x9a
> 
> Can you do something about this horde of \x9a's appended to your every
> email John?

Bizarre, that's the first time someone has mentioned that.  It appears to
be a misfeature of Thunderbird which I switched to last year after kmail
in kde5 officially moved to "unusable trash fire" status.  It doesn't show
up locally, and the signature file I'm using doesn't contain them:

% hexdump .signature 
0000000 2d 2d 20 0a 4a 6f 68 6e 20 42 61 6c 64 77 69 6e
0000010 0a                                             
0000011

Switching to using an inline signature instead of a signature file didn't
fix it either. :(  I haven't found an existing bug report for this yet.

-- 
John Baldwin

                                                                            



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f917e2f2-67f5-e3f7-cb53-0768626b31c2>