Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Oct 2010 11:18:08 -0400
From:      John Nielsen <john@jnielsen.net>
To:        Rui Paulo <rpaulo@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r213765 - head/sys/dev/aic7xxx/aicasm
Message-ID:  <80A99C4D-ACAF-45CD-BE51-3B7560A85D96@jnielsen.net>
In-Reply-To: <201010131033.o9DAX1EE080534@svn.freebsd.org>
References:  <201010131033.o9DAX1EE080534@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
I'm migrating a box from 8-STABLE to -CURRENT this morning and this =
commit seems to break buildkernel:

cc -O2 -pipe -nostdinc -I/usr/include -I. =
-I/usr/src/sys/dev/aic7xxx/aicasm -std=3Dgnu99  -Wsystem-headers -Werror =
-Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes =
-Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual =
-Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align =
-Wno-pointer-sign -c aicasm_scan.c
cc1: warnings being treated as errors
/usr/src/sys/dev/aic7xxx/aicasm/aicasm_scan.l:840: warning: function =
declaration isn't a prototype
*** Error code 1

I don't have any custom CFLAGS, etc defined. Commenting out the new =
#defines from this patch allows the build to continue.

I'm guessing this doesn't happen on machines already running -CURRENT or =
tinderbox (and others) would have noticed. However if this is (going to =
be) a supported upgrade path from 8.x to 9.0 perhaps there's a way to =
make both clang and gcc from 8.x happy?

JN

On Oct 13, 2010, at 6:33 AM, Rui Paulo wrote:

> Author: rpaulo
> Date: Wed Oct 13 10:33:01 2010
> New Revision: 213765
> URL: http://svn.freebsd.org/changeset/base/213765
>=20
> Log:
>  Define YY_NO_INPUT. This makes aicasm buildable by clang with Werror
>  turned on.
>=20
> Modified:
>  head/sys/dev/aic7xxx/aicasm/aicasm_macro_scan.l
>  head/sys/dev/aic7xxx/aicasm/aicasm_scan.l
>=20
> Modified: head/sys/dev/aic7xxx/aicasm/aicasm_macro_scan.l
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/dev/aic7xxx/aicasm/aicasm_macro_scan.l	Wed Oct 13 =
10:31:32 2010	(r213764)
> +++ head/sys/dev/aic7xxx/aicasm/aicasm_macro_scan.l	Wed Oct 13 =
10:33:01 2010	(r213765)
> @@ -61,6 +61,7 @@
> #include "aicasm_symbol.h"
> #include "aicasm_macro_gram.h"
>=20
> +#define YY_NO_INPUT
> #define MAX_STR_CONST 4096
> static char string_buf[MAX_STR_CONST];
> static char *string_buf_ptr;
>=20
> Modified: head/sys/dev/aic7xxx/aicasm/aicasm_scan.l
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/dev/aic7xxx/aicasm/aicasm_scan.l	Wed Oct 13 10:31:32 2010	=
(r213764)
> +++ head/sys/dev/aic7xxx/aicasm/aicasm_scan.l	Wed Oct 13 10:33:01 2010	=
(r213765)
> @@ -61,6 +61,7 @@
> #include "aicasm_symbol.h"
> #include "aicasm_gram.h"
>=20
> +#define YY_NO_INPUT
> /* This is used for macro body capture too, so err on the large size. =
*/
> #define MAX_STR_CONST 4096
> static char string_buf[MAX_STR_CONST];
> _______________________________________________
> svn-src-head@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to =
"svn-src-head-unsubscribe@freebsd.org"
>=20




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?80A99C4D-ACAF-45CD-BE51-3B7560A85D96>