Date: Sat, 4 Jun 2016 10:38:33 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mark Millard <markmi@dsl-only.net>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: svn commit: r301394 - head [If X_COMPILER_TYPE is defined, do not use it, otherwise use it?] Message-ID: <b4fa74f2-c3d3-fd2f-f3a0-124eee6eab57@FreeBSD.org> In-Reply-To: <23DACF49-E75D-4D49-BEB1-621500BC907A@dsl-only.net> References: <23DACF49-E75D-4D49-BEB1-621500BC907A@dsl-only.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--WXp4voTb2LoiTSe57PCdhIbSH7E1DMetM
Content-Type: multipart/mixed; boundary="wfb4BhwW7tSAf7Dgo8U1W5cAuCQ8rRh4X"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Mark Millard <markmi@dsl-only.net>,
FreeBSD Current <freebsd-current@freebsd.org>
Message-ID: <b4fa74f2-c3d3-fd2f-f3a0-124eee6eab57@FreeBSD.org>
Subject: Re: svn commit: r301394 - head [If X_COMPILER_TYPE is defined, do not
use it, otherwise use it?]
References: <23DACF49-E75D-4D49-BEB1-621500BC907A@dsl-only.net>
In-Reply-To: <23DACF49-E75D-4D49-BEB1-621500BC907A@dsl-only.net>
--wfb4BhwW7tSAf7Dgo8U1W5cAuCQ8rRh4X
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 6/4/2016 10:35 AM, Mark Millard wrote:
> From the commit report:
>=20
>> +.if defined(X_COMPILER_TYPE)
>> CROSSENV+=3D COMPILER_VERSION=3D${COMPILER_VERSION} \
>> COMPILER_TYPE=3D${COMPILER_TYPE} \
>> COMPILER_FREEBSD_VERSION=3D${COMPILER_FREEBSD_VERSION}
>=20
> This does not use X_COMPILER_TYPE when it is defined.
>=20
>> +.else
>> +CROSSENV+=3D COMPILER_VERSION=3D${X_COMPILER_VERSION} \
>> + COMPILER_TYPE=3D${X_COMPILER_TYPE} \
>> + COMPILER_FREEBSD_VERSION=3D${X_COMPILER_FREEBSD_VERSION}
>=20
> This tries to use the undefined X_COMPILER_TYPE.
>=20
>> +.endif
>=20
>=20
>=20
> Overall:
>=20
> A not seems to be missing or instead the nested code blocks need to be =
swapped.
>=20
I'm an idiot, thanks.
--=20
Regards,
Bryan Drewery
--wfb4BhwW7tSAf7Dgo8U1W5cAuCQ8rRh4X--
--WXp4voTb2LoiTSe57PCdhIbSH7E1DMetM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJXUxIZAAoJEDXXcbtuRpfP4N4H/2Ag9YZEOC3EBID3OQwd/cKT
3D5mJ07IGr1FZ0Ol90PUfYM+JS4iFgpMI56lQ3EwtHWMcss0JGzFhwlr/s51aVxg
LZm8l2gebwXUoWx/DlrAEOryU+I5u12kGd37Felrugmm8zMMWzmF1TxJU1IKBt9F
AyBVmqFjY9GqJ7DU62qa5nSDtPZiH0QNighkdyv5i1RxQ/n+4Uf+lw4fw0+1W5gG
ymBQXOMXhHswk3JL1PIt35KzbAdLEq4Makcf2kpFXkAfKOizixHdhDtO6+Z0ZYwY
WZ+NILEUpCHZpczv55P3cyjaJ6OziPua/kHKJnnzGzJRDlRV8jXKKjzfQJ8d6bA=
=W+HW
-----END PGP SIGNATURE-----
--WXp4voTb2LoiTSe57PCdhIbSH7E1DMetM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b4fa74f2-c3d3-fd2f-f3a0-124eee6eab57>