Date: Thu, 7 Feb 2002 15:52:04 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Peter Wemm <peter@wemm.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha db_trace.c locore.s machdep.c pmap.c prom.c sys_machdep.c vm_machdep.c src/sys/alpha/linux linux_machdep.c linux_sysvec.c src/sys/alpha/osf1 imgact_osf1.c src/sys/compat/pecoff imgact_pecoff.c src/sys/ddb db_ps.c ... Message-ID: <Pine.BSF.4.21.0202071541300.91961-100000@InterJet.elischer.org> In-Reply-To: <20020207233855.C793239F1@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 7 Feb 2002, Peter Wemm wrote:
> Julian Elischer wrote:
> >
> >
> > On Thu, 7 Feb 2002, Andrew Gallatin wrote:
> >
> > >
> > >
> > > Peter Wemm [peter@wemm.org] wrote:
> > > > Julian Elischer wrote:
> > > > > julian 2002/02/07 12:58:48 PST
> > > >
> > > > > Reviewed by: peter@freebsd.org, gallatin@cs.duke.edu, benno rice,
> > > >
> > > > NO! This was *NOT* reviewed by me. I haven't even *seen* it!
> >
> > Ummm we spent two hours together on the phone going through these
> > changes...
>
> No, that was the kse diff, on sunday.. You had not even started this diff
> then.
This diff IS that diff with the bigger changes backed out.
I generated it from the other one, and sent you a pointer to it on Monday
at 9pm.
> I said on many occasions during that readthrough that there were
> problems that should be fixed before committing, and that both you and I
> would read through the diff before it was committed, since it is blatently
> obvious where the mistakes are.
>
> This kind of thing stands out like a sore thumb:
>
> @@ -2331,15 +2332,18 @@
> ttyprintf(tp, "empty foreground process group\n");
> else {
> mtx_lock_spin(&sched_lock);
>
> +
> /* Pick interesting process. */
> for (pick = NULL; p != 0; p = LIST_NEXT(p, p_pglist))
> if (proc_compare(pick, p))
> pick = p;
>
> Maybe I overreacted. Dealing with pacbell is not a good way to calm the
> nerves. But I also don't appreciate being listed as a reviewer when I
> haven't even seen the actual change, and when I explicitly said "let me
> read it first".
Ok maybe my frustration at having sent you the diff on Monday and heard
nothing from you by thursday afternoon was getting to me.. I still think
you are accuratly described as a reviewer because there is NOTHING in
this diff that was not part of the bigger diff we went over on Sunday.
It is a pure subset of that diff, so we DID look at it together. I
presumed that since others had looked at it, (e.g. Benno said that he had
some issues with PPC but that he would rather I commit it so he could fix
it after) and it had actually been tested on other machines than my own,
(e.g. Andrew's alpha), that since there wasn't anything you saw worth
really complainign about, that waiting for you further was not really
that important. After all it IS CVS and we can always fix things.
>
> Cheers,
> -Peter
> --
> Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
> "All of this is for nothing if we don't go to the stars" - JMS/B5
>
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0202071541300.91961-100000>