Date: Tue, 7 Jul 2020 21:54:51 +0800 From: Li-Wen Hsu <lwhsu@freebsd.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r541417 - in head: audio/bambootracker audio/zynaddsubfx comms/nanovna-saver comms/openzwave-devel comms/telldus-core comms/tlf databases/arrow deskutils/cairo-dock-plugins devel/bossa ... Message-ID: <CAKBkRUyOrMAij20X99TChcAp24sV9EbwWfiJ6rH9ctPLTiz_%2Bg@mail.gmail.com> In-Reply-To: <afdca732-9193-41da-88f6-61cdfc99d824@www.fastmail.com> References: <202007071227.067CRINg025699@repo.freebsd.org> <afdca732-9193-41da-88f6-61cdfc99d824@www.fastmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 7, 2020 at 9:11 PM Tobias Kortkamp <tobik@freebsd.org> wrote: > > On Tue, Jul 7, 2020, at 12:53, Li-Wen Hsu wrote: > > On Tue, Jul 7, 2020 at 8:27 PM Tobias Kortkamp <tobik@freebsd.org> wrote: > > > > > > Author: tobik > > > Date: Tue Jul 7 12:27:18 2020 > > > New Revision: 541417 > > > URL: https://svnweb.freebsd.org/changeset/ports/541417 > > > > > > Log: > > > Clean up some things > > > > > > Reported by: portscan and common sense > > > > Hi Tobias, > > > > I am somehow worried that this commit might cause some people's > > objection. It does fix many things, which is great, but also: > > - Changed (direct) dependency but not bump PORTREVISION (comms/nanovna-saver) > > I did not change any dependencies. What did I miss? oh I mean direct dependency, it drops qt5 directly. It's not a serious issue, though. > > - Touched some style preference (print/pdfchain) > > The previous style causes active harm in readability and causes > additional cognitve load on committers. See the commit message of > r541362 for a direct example of this. Also style fixes are very > much covered by the blanket. I quote chapter 5.5 from the Porter's > Handbook: > > "We reserve the right to modify the maintainer's submission to better > match existing policies and style of the Ports Collection without > explicit blessing from the submitter or the maintainer. Also, large > infrastructural changes can result in a port being modified without > the maintainer's consent. These kinds of changes will never affect > the port's functionality." > > https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-maintainer.html > > For pdfchain it IMHO should have been done before the initial import into > the tree. Yeah I also noticed that r541362 and rethinking if I should change that while importing. I didn't do that because I wasn't aware that there is a strict rule about this and it still has some benefits, e.g., easier to track adding/deleting. I chose to leave as it is because I wanted to respect the submitter's choice. Anyway, I'm fine with both styles. > > - Without notifying port's maintainer nor not having approval from porgmr > > > > Sorry that if I didn't notice there was a policy change that those > > changes are also covered by blanket approval, and I'm a bit worried > > about the last one, maybe the better way is file a PR with the patch > > and let MAINTAINER have time to response (or use maintainer timeout > > after two weeks)? > > If I have misinterpreted the blanket and if commits like this are > indeed not covered by it, I would rather refrain from making commits > like this in the future because I will not cause extra work for > myself and file PRs for these trivial fixes. That is asking way > too much. I can understand what you think. I neither support or discourage you from doing so. In fact, I'm very appreciative of you doing these work, just being a bit worried that this might be too aggressive and I'm afraid that it might cause conflicts (hope not). Just sending a mail to check with you from a friend's perspective. And yeah, there should be more handy tools for working on patch and PR. > > BTW, what's "porscan"? I didn't notice that tool. Sounds useful and > > can you tell me more about it? > > It's part of ports-mgmt/portfmt and will flag stuff like you see > here. I run it regularly and results are published here: > https://pkg.tobik.me/portscan/ Thanks for the information, that looks very useful. Li-Wen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUyOrMAij20X99TChcAp24sV9EbwWfiJ6rH9ctPLTiz_%2Bg>